Using [GS]etWindowLong{Ptr} in tests
Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, ...). I think this is somewhat confusing. API offers both A- an W- versions of this function, while at my first glance I cannot firmly decide, what used name does refer to. Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ? Same question stands for [GS]etWindowLong().
"Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, ...). I think this is somewhat confusing. API offers both A- an W- versions of this function, while at my first glance I cannot firmly decide, what used name does refer to.
Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ?
Same question stands for [GS]etWindowLong().
The code is correct as it is now, there is no need to change anything. -- Dmitry.
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
API offers both A- an W- versions of this function, while at my first glance I cannot firmly decide, what used name does refer to.
... The code is correct as it is now,
I talk about corectness of the naming, not of a code.
there is no need to change anything.
Then could you answer me, please, why there is used both SetWindowLongPtrA() and SetWindowLongPtr() in the same file (dlls/user32/tests/win.c) ? Didn't you find that confusing?
"Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
Then could you answer me, please, why there is used both SetWindowLongPtrA() and SetWindowLongPtr() in the same file (dlls/user32/tests/win.c) ?
Since I have written a large part of that code, I can answer it: some parts have been written under Windows, therefore no A/W suffix, since that's how it's usually done in the Windows world, some code has been copied from Wine parts, and they obviously have it.
Didn't you find that confusing?
No. -- Dmitry.
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
Since I have written a large part of that code, I can answer it: some parts have been written under Windows, therefore no A/W suffix, since that's how it's usually done in the Windows world, some code has been copied from Wine parts, and they obviously have it.
Did that restrict us from using single naming scheme?
Didn't you find that confusing?
No.
The project needs some voting mechanism, I'd say. Well, Alexandre's vote would get an additional queue then, of course. ;)
"Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
Since I have written a large part of that code, I can answer it: some parts have been written under Windows, therefore no A/W suffix, since that's how it's usually done in the Windows world, some code has been copied from Wine parts, and they obviously have it.
Did that restrict us from using single naming scheme?
Personally I don't see any point in that. The tests are not forced to use A/W API suffixes, that's done on purpose.
Didn't you find that confusing?
No.
The project needs some voting mechanism, I'd say. Well, Alexandre's vote would get an additional queue then, of course. ;)
We don't enforce any code style in the Wine code, why do we need that in the tests (which strictly speaking are not part of Wine)? -- Dmitry.
On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
The project needs some voting mechanism, I'd say.
It's already in place.
Namely how can I enter a new voting for renaming "*" to "*A", then?
You send in a patch to wine-patches, and it either gets accepted or rejected by the community, and ultimately, by Alexandre. -- James Hawkins
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
The project needs some voting mechanism, I'd say.
It's already in place.
Namely how can I enter a new voting for renaming "*" to "*A", then?
You send in a patch to wine-patches, and it either gets accepted or rejected by the community, and ultimately, by Alexandre.
Didn't I just say that Alexandre's vote is a different thing from what I want to see? :)
On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
The project needs some voting mechanism, I'd say.
It's already in place.
Namely how can I enter a new voting for renaming "*" to "*A", then?
You send in a patch to wine-patches, and it either gets accepted or rejected by the community, and ultimately, by Alexandre.
Didn't I just say that Alexandre's vote is a different thing from what I want to see? :)
Then you missed the first part of the sentence, about the community. The problem is, most of the community is on or near Alexandre's level, so we tend to agree on most things, but Alexandre has said before that if the entire community wants something he doesn't want, he'll accept it (though I can't quote this, because I don't remember when it was said). -- James Hawkins
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote:
The project needs some voting mechanism, I'd say.
It's already in place.
Namely how can I enter a new voting for renaming "*" to "*A", then?
You send in a patch to wine-patches, and it either gets accepted or rejected by the community, and ultimately, by Alexandre.
Didn't I just say that Alexandre's vote is a different thing from what I want to see? :)
Then you missed the first part of the sentence, about the community.
I don't think so. "Accepted or rejected by the community" isn't numerical result of voting (which Dmitry wants to ensure me is present), while for example list from the page [1] is.
The problem is, most of the community is on or near Alexandre's level, so we tend to agree on most things,
I am fine with it, and this isn't a problem, IMHO. [1] http://appdb.winehq.org/votestats.php
On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Fri, 8 Jun 2007, James Hawkins wrote:
* On 6/8/07, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote:
* On Sat, 9 Jun 2007, Dmitry Timoshkov wrote:
* "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote: > > The project needs some voting mechanism, I'd say.
It's already in place.
Namely how can I enter a new voting for renaming "*" to "*A", then?
You send in a patch to wine-patches, and it either gets accepted or rejected by the community, and ultimately, by Alexandre.
Didn't I just say that Alexandre's vote is a different thing from what I want to see? :)
Then you missed the first part of the sentence, about the community.
I don't think so. "Accepted or rejected by the community" isn't numerical result of voting (which Dmitry wants to ensure me is present), while for example list from the page [1] is.
Well, you haven't put anything to a vote, so how you can say there is no voting? Give it a shot, and see what happens. You seem to miss the effect of the community though. If more developers in the community wanted this change you are proposing, they would speak up and say so, and there would be more patches headed to wine-patches that make the changes. That hasn't happened, so you can pretty accurately guess that, were you to put it to a vote, the resolution would probably not pass.
The problem is, most of the community is on or near Alexandre's level, so we tend to agree on most things,
I am fine with it, and this isn't a problem, IMHO.
-- James Hawkins
Saulius Krasuckas <saulius2(a)ar.fi.lt> writes:
I don't think so. "Accepted or rejected by the community" isn't numerical result of voting (which Dmitry wants to ensure me is present), while for example list from the page [1] is.
Things don't get decided by popularity, but by technical merit. If you can make a good technical argument for a change it will go in; if you can't, gathering votes for it won't help. -- Alexandre Julliard julliard(a)winehq.org
* On Fri, 8 Jun 2007, Alexandre Julliard wrote:
Things don't get decided by popularity, but by technical merit. If you can make a good technical argument for a change it will go in; if you can't, gathering votes for it won't help.
Ok, so what would you say about a benefit of renaming of SetWindowLongPtr to SetWindowLongPtrA ?
Saulius Krasuckas <saulius2(a)ar.fi.lt> writes:
Things don't get decided by popularity, but by technical merit. If you can make a good technical argument for a change it will go in; if you can't, gathering votes for it won't help.
Ok, so what would you say about a benefit of renaming of SetWindowLongPtr to SetWindowLongPtrA ?
I wouldn't say anything at this point. It's up to you to explain what the benefits are, why SetWindowLongPtr and not others, why Dmitry is wrong in his objections, etc. That's how you make a good technical argument. -- Alexandre Julliard julliard(a)winehq.org
* On Fri, 8 Jun 2007, Alexandre Julliard wrote:
* Saulius Krasuckas <saulius2(a)ar.fi.lt> writes:
Ok, so what would you say about a benefit of renaming of SetWindowLongPtr to SetWindowLongPtrA ?
I wouldn't say anything at this point. It's up to you to explain what the benefits are,
Well, I already said: there are two names used in one file, both for a single function. What if I add new test for it? I just don't know which name to use. What if I use SetWindowLongPtr and SetWindowLongPtrA interchangibly in my patch? I don't believe it's OK.
why SetWindowLongPtr and not others,
I am sorry, I didn't stuck upon other fns. I would ask about them too.
why Dmitry is wrong in his objections, etc.
He isn't wrong neither right. His arguments just didn't persuade me.
participants (4)
-
Alexandre Julliard -
Dmitry Timoshkov -
James Hawkins -
Saulius Krasuckas