Re: paint: Add new program

[Austin English]

On Mon, Oct 20, 2008 at 8:27 PM, Hirofumi Katayama
<katayama.hirofumi.mz(a)gmail.com> wrote:
> See attachment.

Howdy,

Thanks for the patch, a few comments:
> From b5fc5d2fc2c74507aa2dcf2daa4fe404e9b1ba06 Mon Sep 17 00:00:00 2001
> From: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
> Date: Tue, 21 Oct 2008 03:41:08 +0900
> Subject: [PATCH] paint: Add new program

---
 .gitignore                  |    1 +
 configure                   |   11 +
 configure.ac                |    1 +
Don't include changes to configure, it is built automatically from
configure.ac. Make any needed changes there.

Your patch doesn't apply cleanly:
bash-3.2$ git apply ../paint.txt
../paint.txt:425: trailing whitespace.

../paint.txt:428: trailing whitespace.

../paint.txt:438: trailing whitespace.

../paint.txt:449: trailing whitespace.

../paint.txt:765: trailing whitespace.

warning: configure has type 100755, expected 100644
warning: tools/make_makefiles has type 100755, expected 100644
warning: squelched 71 whitespace errors
warning: 76 lines add whitespace errors.

Why are you changing the permissions on those files?
-- 
-Austin