Re: [PATCH 01/10] vulkan: Add Wine vulkan header.

[Józef Kucia]

On Tue, Oct 31, 2017 at 6:24 PM, Roderick Colenbrander
<thunderbird2k(a)gmail.com> wrote:
> Signed-off-by: Roderick Colenbrander <thunderbird2k(a)gmail.com>
> ---
>  include/wine/vulkan.h | 2889 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 2889 insertions(+)
>  create mode 100644 include/wine/vulkan.h
>
> diff --git a/include/wine/vulkan.h b/include/wine/vulkan.h
> new file mode 100644
> index 0000000000..b86702e43f
> --- /dev/null
> +++ b/include/wine/vulkan.h
> @@ -0,0 +1,2889 @@
> +/* Automatically generated from Vulkan vk.xml; DO NOT EDIT! */

This file is generated by a custom code generator, right? When do you
plan to submit the code generator? In a way it might be easier to
review the code generator than the generated code.
> +
> +#ifndef __WINE_VULKAN_H
> +#define __WINE_VULKAN_H

[PATCH 01/10] vulkan: Add Wine vulkan header.

[Roderick Colenbrander]

On Wed, Nov 1, 2017 at 3:06 AM, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
> On Tue, Oct 31, 2017 at 6:24 PM, Roderick Colenbrander
> <thunderbird2k(a)gmail.com> wrote:
> > Signed-off-by: Roderick Colenbrander <thunderbird2k(a)gmail.com>
> > ---
> >  include/wine/vulkan.h | 2889 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 2889 insertions(+)
> >  create mode 100644 include/wine/vulkan.h
> >
> > diff --git a/include/wine/vulkan.h b/include/wine/vulkan.h
> > new file mode 100644
> > index 0000000000..b86702e43f
> > --- /dev/null
> > +++ b/include/wine/vulkan.h
> > @@ -0,0 +1,2889 @@
> > +/* Automatically generated from Vulkan vk.xml; DO NOT EDIT! */
>
> This file is generated by a custom code generator, right? When do you
> plan to submit the code generator? In a way it might be easier to
> review the code generator than the generated code.
> > +
> > +#ifndef __WINE_VULKAN_H
> > +#define __WINE_VULKAN_H

I will submit the code generation script once a sufficient amount of
the ICD. It is just that right now I need to do hacks here and there
to prevent it from generating everything the full ICD just so I can
submit piece by piece.