Re: Patch for font size = 0x7fff in dialog templates

[Koro]

> This is a patch that fixes a discrepancy between WINE's dialog manager
> and the real Windows one. If, in a dialog template, (assuming DS_SETFONT
> is set) the font size is 0x7fff, it means that the dialog manager must
> use the message box font and not read the rest of the font data
> (facename and others) off the template.
>
> This quirk is "documented" in a comment there, and I have myself
> confirmed this behavior with some of my code a few months ago:
> http://blogs.msdn.com/oldnewthing/archive/2005/04/29/412577.aspx#413552
>
> Sending patch as attachment because putting it inline would probably
> word-wrap it all over the place.

What was wrong with my patch? I never heard of it again, and last time I 
checked http://source.winehq.org/source/dlls/user32/dialog.c it still 
wasn't there.

Patch for font size = 0x7fff in dialog templates

[John Klehm]

On Sun, Aug 31, 2008 at 1:25 PM, Koro <webmaster(a)korosoft.net> wrote:
> > This is a patch that fixes a discrepancy between WINE's dialog manager
> > and the real Windows one. If, in a dialog template, (assuming DS_SETFONT
> > is set) the font size is 0x7fff, it means that the dialog manager must
> > use the message box font and not read the rest of the font data
> > (facename and others) off the template.
> >
> > This quirk is "documented" in a comment there, and I have myself
> > confirmed this behavior with some of my code a few months ago:
> > http://blogs.msdn.com/oldnewthing/archive/2005/04/29/412577.aspx#413552
> >
> > Sending patch as attachment because putting it inline would probably
> > word-wrap it all over the place.
>
> What was wrong with my patch? I never heard of it again, and last time I
> checked http://source.winehq.org/source/dlls/user32/dialog.c it still
> wasn't there.

You must use your real name when sending in patches.

Regards,
--John Klehm