Re: [1/5] ole32: Change the base IStorage filename to a pointer type.

[Paul Vriens]

On 12/07/2009 10:17 PM, Vincent Povirk wrote:
> +    /* Stat always returns the full path, even for files opened with a relative path. */
> +    GetCurrentDirectoryW(MAX_PATH, prev_dir);
> +
> +    GetTempPathW(MAX_PATH, temp);
> +
> +    SetCurrentDirectoryW(temp);
> +
> +    GetFullPathNameW(filename, MAX_PATH, full_path,&rel_path);
> +
> +    r = StgCreateDocfile( rel_path, STGM_CREATE | STGM_SHARE_EXCLUSIVE |
> +                            STGM_READWRITE |STGM_TRANSACTED, 0,&stg);

Hi Vincent,

These tests currently crash on Win9x/WinME due . I rewrote that test to 
just use A-functions but there are loads of lstrcmpW tests that of 
course always fail on Win9x (not implemented).

Do you think it's worthwhile changing these tests to cope with Win9x/WinMe?

-- 
Cheers,

Paul.

[1/5] ole32: Change the base IStorage filename to a pointer type.

[Vincent Povirk]

On Wed, Dec 9, 2009 at 8:26 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> These tests currently crash on Win9x/WinME due . I rewrote that test to just
> use A-functions but there are loads of lstrcmpW tests that of course always
> fail on Win9x (not implemented).

I always forget about that. Sorry. Should I write a patch, or do you
have it covered?
> Do you think it's worthwhile changing these tests to cope with Win9x/WinMe?

Um, I dunno. I guess it'd be preferable.

-- 
Vincent Povirk

[1/5] ole32: Change the base IStorage filename to a pointer type.

[Paul Vriens]

On 12/09/2009 05:43 PM, Vincent Povirk wrote:
> On Wed, Dec 9, 2009 at 8:26 AM, Paul Vriens<paul.vriens.wine(a)gmail.com>  wrote:
> > These tests currently crash on Win9x/WinME due . I rewrote that test to just
> > use A-functions but there are loads of lstrcmpW tests that of course always
> > fail on Win9x (not implemented).
>
> I always forget about that. Sorry. Should I write a patch, or do you
> have it covered?

I can do it, no problem. That gives you time to implement stuff ;)
> > Do you think it's worthwhile changing these tests to cope with Win9x/WinMe?
>
> Um, I dunno. I guess it'd be preferable.

OK. I'll copy a strcmp_wa() function from somewhere to replace the 
lstrcmpW's and change some functions to the A-equivalent.

-- 
Cheers,

Paul.