still many warnings from Mesa
As far as I can see, patches from Raphaël resolved many related warnings I used to see (Thanks!), but using XFree86 4.3 and Mesa 3.4.2 I still get the following. Could someone please have a look at addressing these? directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast opengl_norm.c:26: warning: implicit declaration of function `glActiveTextureARB' opengl_norm.c:208: warning: implicit declaration of function `glClientActiveTextureARB' opengl_norm.c:2150: warning: implicit declaration of function `glMultiTexCoord1dARB' opengl_norm.c:2160: warning: implicit declaration of function `glMultiTexCoord1dvARB' opengl_norm.c:2170: warning: implicit declaration of function `glMultiTexCoord1fARB' opengl_norm.c:2180: warning: implicit declaration of function `glMultiTexCoord1fvARB' opengl_norm.c:2190: warning: implicit declaration of function `glMultiTexCoord1iARB' opengl_norm.c:2200: warning: implicit declaration of function `glMultiTexCoord1ivARB' opengl_norm.c:2210: warning: implicit declaration of function `glMultiTexCoord1sARB' opengl_norm.c:2220: warning: implicit declaration of function `glMultiTexCoord1svARB' opengl_norm.c:2230: warning: implicit declaration of function `glMultiTexCoord2dARB' opengl_norm.c:2240: warning: implicit declaration of function `glMultiTexCoord2dvARB' opengl_norm.c:2250: warning: implicit declaration of function `glMultiTexCoord2fARB' opengl_norm.c:2260: warning: implicit declaration of function `glMultiTexCoord2fvARB' opengl_norm.c:2270: warning: implicit declaration of function `glMultiTexCoord2iARB' opengl_norm.c:2280: warning: implicit declaration of function `glMultiTexCoord2ivARB' opengl_norm.c:2290: warning: implicit declaration of function `glMultiTexCoord2sARB' opengl_norm.c:2300: warning: implicit declaration of function `glMultiTexCoord2svARB' opengl_norm.c:2310: warning: implicit declaration of function `glMultiTexCoord3dARB' opengl_norm.c:2320: warning: implicit declaration of function `glMultiTexCoord3dvARB' opengl_norm.c:2330: warning: implicit declaration of function `glMultiTexCoord3fARB' opengl_norm.c:2340: warning: implicit declaration of function `glMultiTexCoord3fvARB' opengl_norm.c:2350: warning: implicit declaration of function `glMultiTexCoord3iARB' opengl_norm.c:2360: warning: implicit declaration of function `glMultiTexCoord3ivARB' opengl_norm.c:2370: warning: implicit declaration of function `glMultiTexCoord3sARB' opengl_norm.c:2380: warning: implicit declaration of function `glMultiTexCoord3svARB' opengl_norm.c:2390: warning: implicit declaration of function `glMultiTexCoord4dARB' opengl_norm.c:2400: warning: implicit declaration of function `glMultiTexCoord4dvARB' opengl_norm.c:2410: warning: implicit declaration of function `glMultiTexCoord4fARB' opengl_norm.c:2420: warning: implicit declaration of function `glMultiTexCoord4fvARB' opengl_norm.c:2430: warning: implicit declaration of function `glMultiTexCoord4iARB' opengl_norm.c:2440: warning: implicit declaration of function `glMultiTexCoord4ivARB' opengl_norm.c:2450: warning: implicit declaration of function `glMultiTexCoord4sARB' opengl_norm.c:2460: warning: implicit declaration of function `glMultiTexCoord4svARB' Thanks, Gerald
Could someone please have a look at addressing these?
Well, I think the only way to safely remove these are by using --disable-opengl. Ie I will detect that one has 'ABI-compliant' GL headers (ie that it defines the glXGetProcAddressARB / multi-texture prototypes) and disable OpenGL build if not. I know it's a Linux only ABI but well, people on other platforms can fix the issue if they need it to be fixed :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
On Mon, 30 Jun 2003, Lionel Ulmer wrote:
Could someone please have a look at addressing these? Well, I think the only way to safely remove these are by using --disable-opengl.
Nah. It works perfectly, without a single warning, once #define GL_GLEXT_PROTOTYPES is added, but Raphaël didn't want that due to problems with broken nVIDEA drivers or somthing like that.
I know it's a Linux only ABI but well, people on other platforms can fix the issue if they need it to be fixed :-)
This is not a Linux versus FreeBSD issue. Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
Nah. It works perfectly, without a single warning, once
#define GL_GLEXT_PROTOTYPES
is added, but Raphaël didn't want that due to problems with broken nVIDEA drivers or somthing like that. (...) This is not a Linux versus FreeBSD issue.
Well, the Linux ABI tells this : " 4.4. glx.h must include the prototype of the glXGetProcAddressARB extension described above. 4.5. All OpenGL 1.2 and ARB_multitexture, GLU 1.3, and GLX 1.3 entry points and enumerants must be present in the corresponding header files gl.h, glu.h, and glx.h, even if only OpenGL 1.1 is implemented at runtime by the associated runtime libraries. " So if your system was compliant, you should have all the glMulti* prototypes defined in your gl.h file and glXGetProcAddressARB too.... So you should not have any warning. Nothing is mentionned in the ABI about any need for 'GL_GLEXT_PROTOTYPES' protection of these calls, so well, I still think that it's somehow a problem in your headers :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
On Mon, 30 Jun 2003, Lionel Ulmer wrote:
This is not a Linux versus FreeBSD issue. Well, the Linux ABI tells this :
There is no such thing that is widely known as the "Linux ABI" _and_ that mandates things like this. Do you refer to http://oss.sgi.com/projects/ogl-sample/ABI/ ?
" 4.4. glx.h must include the prototype of the glXGetProcAddressARB extension described above.
If we're nitpicking, this has nothing to do with an ABI, but with an API. If we are not nitpicking, this problem still exists with Mesa-5.0.1, so it would be nice to address it (as Raphaël once suggested). Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all,
Well, the Linux ABI tells this :
There is no such thing that is widely known as the "Linux ABI" _and_ that mandates things like this.
Do you refer to http://oss.sgi.com/projects/ogl-sample/ABI/ ?
" 4.4. glx.h must include the prototype of the glXGetProcAddressARB extension described above.
If we're nitpicking, this has nothing to do with an ABI, but with an API.
If we are not nitpicking, this problem still exists with Mesa-5.0.1, so it would be nice to address it (as Raphaël once suggested).
Well, For what i have seen, too few headers are "ABI correct" (only some SGI and HP headers). So i prefer to do fixes to not have more any problems with "not corrects headers" than waiting for corrects one (or if you prefer you can put correct headers on wine source tree). Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/AJ1Hp7NA3AmQTU4RAg7bAJ9wVIHvKEjGpomjZhKFbdjBu0wkoACgltdz a/yhXUQB89VUOxXx9qDbLzg= =+vkY -----END PGP SIGNATURE-----
So i prefer to do fixes to not have more any problems with "not corrects headers" than waiting for corrects one (or if you prefer you can put correct headers on wine source tree).
Well, you are free to fix those warnings if you wish (I won't do it as it works perfectly well on my system so I cannot test with what I consider broken headers). If you do so, change also the 'make_opengl' Perl script as I would prefer not to always come behind people comitting direct fixes to the auto-generated files as soon as I want to update the files. Lionel -- Lionel Ulmer - http://www.bbrox.org/
There is no such thing that is widely known as the "Linux ABI" _and_ that mandates things like this.
Do you refer to http://oss.sgi.com/projects/ogl-sample/ABI/ ?
Yes.
If we're nitpicking, this has nothing to do with an ABI, but with an API.
Well, the documentation is called an ABI so I take their naming conventions even if in the case of header file definitions I agree with you.
If we are not nitpicking, this problem still exists with Mesa-5.0.1, so it would be nice to address it (as Raphaël once suggested).
Well, feel free to do so, this is a can of worm that I do not particularly like to open (and it works for me (tm)). But I will post a mail on the Mesa-devel mailing list about the glXGetProcAddressARB issue, we will see what I get for an answer :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
On Mon, 30 Jun 2003, Gerald Pfeifer wrote:
Could someone please have a look at addressing these?
It seems recent patches by Raphaël have fixed all these apart from mere four: directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast Thanks a lot! Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
It seems recent patches by Raphaël have fixed all these apart from mere four:
Errrm, I did the changes, not Raphaël :-)
directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast
Well, for these, we need to define 'GLX_GLXEXT_PROTOTYPES' to have the prototype defined... After, I have no idea if this could break things up in case of 'bad' GL headers installed (ie do we prefer 10 people complaining of Wine not compiling or 1 with warnings ?). But at least these warnings are 'less critical' than the GL ones (where some functions had float / double parameters => the generated code was useless). Here, the generated code with or without warnings should be the same :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
It seems recent patches by Raphaël have fixed all these apart from mere four:
Errrm, I did the changes, not Raphaël :-)
lol
directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast
Well, for these, we need to define 'GLX_GLXEXT_PROTOTYPES' to have the prototype defined... After, I have no idea if this could break things up in case of 'bad' GL headers installed (ie do we prefer 10 people complaining of Wine not compiling or 1 with warnings ?).
I think using a function pointer should be better.
But at least these warnings are 'less critical' than the GL ones (where some functions had float / double parameters => the generated code was useless). Here, the generated code with or without warnings should be the same :-)
Lionel
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/DHFCp7NA3AmQTU4RAkCKAJ97YaahOXpdhnxeR3goZ7pH0K9LHACfX5jW sRwpA6B2h9BXSSr7d4EbBUs= =KMgY -----END PGP SIGNATURE-----
I think using a function pointer should be better.
Hmmm, let me hack this up for OpenGL (wgl.c)... We will see what it gives :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
On Wed, 9 Jul 2003, Lionel Ulmer wrote:
It seems recent patches by Raphaël have fixed all these apart from mere four: Errrm, I did the changes, not Raphaël :-)
Oops, sorry. So, thanks a lot, Lionel! :-)
But at least these warnings are 'less critical' than the GL ones (where some functions had float / double parameters => the generated code was useless).
Indeed that's why I've been trying to track down/reduce warnings were possible (not because I'm bored or pedantic ;-) ). Thanks for attacking this! Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
On Wed, 9 Jul 2003, Gerald Pfeifer wrote:
So, thanks a lot, Lionel! :-)
And thanks again for yesterday's update! (There is only a single warning left now: directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB') Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le Vendredi 11 Juillet 2003 13:05, Gerald Pfeifer a écrit :
On Wed, 9 Jul 2003, Gerald Pfeifer wrote:
So, thanks a lot, Lionel! :-)
And thanks again for yesterday's update!
(There is only a single warning left now: directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB')
yes, this is mine. But you must wait before i can fix it (i'm working on a big piece of code now)
Gerald
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/EzTep7NA3AmQTU4RAuaiAKCFadYjBrWZs3eByVfsjdmGzj25hACfd+Yq LnswDAk5wL5uNscMOQYyj4Y= =9CAg -----END PGP SIGNATURE-----
I found various warnings while compiling and for me, the cause is the patch below. I recently posted a mail wint subject " Compiling warnings in d3d8_private.h". I only post this message, because maybe this appear only to me, and I also wait ;) Bye. ChangeSet ID: 8427 CVSROOT: /home/winehq/opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2003/06/06 13:12:59 Modified files: dlls/d3d8 : utils.c directx.c device.c d3dcore_gl.h d3d8_private.h Log message: Raphael Junqueira <fenix(a)club-internet.fr> Fixed compilation problems. Patch: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8427 Old revision New revision Changes Path 1.4 1.5 +23 -28 wine/dlls/d3d8/utils.c 1.42 1.43 +18 -3 wine/dlls/d3d8/directx.c 1.69 1.70 +2 -4 wine/dlls/d3d8/device.c 1.1 1.2 +141 -23 wine/dlls/d3d8/d3dcore_gl.h 1.34 1.35 +3 -1 wine/dlls/d3d8/d3d8_private.h Em Seg 14 Jul 2003 19:55, Raphaël Junqueira escreveu:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Le Vendredi 11 Juillet 2003 13:05, Gerald Pfeifer a écrit :
On Wed, 9 Jul 2003, Gerald Pfeifer wrote:
So, thanks a lot, Lionel! :-)
And thanks again for yesterday's update!
(There is only a single warning left now: directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB')
yes, this is mine. But you must wait before i can fix it (i'm working on a big piece of code now)
Gerald
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/EzTep7NA3AmQTU4RAuaiAKCFadYjBrWZs3eByVfsjdmGzj25hACfd+Yq LnswDAk5wL5uNscMOQYyj4Y= =9CAg -----END PGP SIGNATURE-----
-- Marcelo Duarte
participants (4)
-
Gerald Pfeifer -
Lionel Ulmer -
Marcelo Duarte -
Raphaël Junqueira