RtlUnicodeStringToInteger prototype missing, and wrong?

[Dan Kegel]

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/kmarch/hh/k...
says

"NTSTATUS
   RtlUnicodeStringToInteger(
     IN PUNICODE_STRING  String,
     IN ULONG  Base  OPTIONAL,
     OUT PULONG  Value
     );
Declared in wdm.h and ntddk.h. Include wdm.h or ntddk.h."

Shouldn't this be declared in wine/include/winternl.h, like
the other Rtl functions?  And shouldn't wine/dlls/ntdll/rtlstr.c
declare it to use an unsigned long instead of an int as
its 2nd arg, and an unsigned long * instead of an int * as
its 3rd arg?

If so, I can submit a patch to fix all that, but as I'm
a total wine newbie, I bet there's something I'm missing.
- Dan

-- 
Dan Kegel
Linux User #78045
http://www.kegel.com

[Francois Gouget]

On Tue, 24 Dec 2002, Dan Kegel wrote:
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/kmarch/hh/k...
> says
>
> "NTSTATUS
>    RtlUnicodeStringToInteger(
>      IN PUNICODE_STRING  String,
>      IN ULONG  Base  OPTIONAL,
>      OUT PULONG  Value
>      );
> Declared in wdm.h and ntddk.h. Include wdm.h or ntddk.h."
>
> Shouldn't this be declared in wine/include/winternl.h, like
> the other Rtl functions?

Microsoft does not declare it in winternl.h. We could create an ntddk.h
or a wdm.h header but these are part of the Windows DDK, not the SDK.
I'm not sure we have 'public' DDK headers in Wine.
> And shouldn't wine/dlls/ntdll/rtlstr.c
> declare it to use an unsigned long instead of an int as
> its 2nd arg, and an unsigned long * instead of an int * as
> its 3rd arg?

Yes. Whatever we do for headers, this function's signature should match
the one you give above.
> If so, I can submit a patch to fix all that, but as I'm
> a total wine newbie, I bet there's something I'm missing.

Please, go ahead, at least to fix the signature.


-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
      Any sufficiently advanced bug is indistinguishable from a feature.
                            -- from some indian guy

[Alexandre Julliard]

Francois Gouget <fgouget(a)free.fr> writes:
> On Tue, 24 Dec 2002, Dan Kegel wrote:
> > Shouldn't this be declared in wine/include/winternl.h, like
> > the other Rtl functions?
>
> Microsoft does not declare it in winternl.h. We could create an ntddk.h
> or a wdm.h header but these are part of the Windows DDK, not the SDK.
> I'm not sure we have 'public' DDK headers in Wine.

Actually that's what winternl.h is for; Microsoft only lists a few
functions in there but we might as well put the others there too. They
will probably end up in Microsoft's winternl.h someday, after a few
more lawsuits...

-- 
Alexandre Julliard
julliard(a)winehq.com