Re: widl: Set name return value (passed by reference) in the alias case alias case in get_user_type.

[Alexandre Julliard]

Gerald Pfeifer <gerald(a)pfeifer.com> writes:
> So, I admit I don't really know this code, but looking at it (triggered 
> by a warning issued by GCC development versions), I noticed that this 
> variable passed by reference is not initialized here.

It's initialized when we return a type, and it doesn't need to be
initialized on NULL return. The code is correct, but you could probably
set the variable to NULL in the caller to silence the warning.

-- 
Alexandre Julliard
julliard(a)winehq.org

widl: Set name return value (passed by reference) in the alias case alias case in get_user_type.

[Gerald Pfeifer]

On Mon, 6 Nov 2017, Alexandre Julliard wrote:
> > So, I admit I don't really know this code, but looking at it (triggered 
> > by a warning issued by GCC development versions), I noticed that this 
> > variable passed by reference is not initialized here.
> > It's initialized when we return a type, and it doesn't need to be
> > initialized on NULL return. The code is correct, but you could probably
> > set the variable to NULL in the caller to silence the warning.

You were right, and I apologize for not following up on this one
back then so you ended up running into it yourself a bit later:

  commit 68cfa7fd03a1ef9f65cc700ea50cfba2be09880f
  Author: Alexandre Julliard <julliard(a)winehq.org>
  Date:   Wed Aug 15 10:48:51 2018 +0200

    widl: Silence a gcc warning.
    
    Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

Gerald

PS: This was (nearly) the last submission/discussion I had in my
Wine backlog; only one, two new patches left. ;-)