[PATCH v2] dstyle: IDirectMusicStyle8 GetDefaultBand return S_FALSE

[Alistair Leslie-Hughes]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48648

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/dmstyle/style.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/dlls/dmstyle/style.c b/dlls/dmstyle/style.c
index 3e480028b9e..5a97dac079a 100644
--- a/dlls/dmstyle/style.c
+++ b/dlls/dmstyle/style.c
@@ -151,11 +151,17 @@ static HRESULT WINAPI IDirectMusicStyle8Impl_EnumBand(IDirectMusicStyle8 *iface,
 }
 
 static HRESULT WINAPI IDirectMusicStyle8Impl_GetDefaultBand(IDirectMusicStyle8 *iface,
-        IDirectMusicBand **ppBand)
+        IDirectMusicBand **band)
 {
-        IDirectMusicStyle8Impl *This = impl_from_IDirectMusicStyle8(iface);
-	FIXME("(%p, %p): stub\n", This, ppBand);
-	return S_OK;
+    IDirectMusicStyle8Impl *This = impl_from_IDirectMusicStyle8(iface);
+    FIXME("(%p, %p): stub\n", This, band);
+
+    if (!band)
+        return E_POINTER;
+
+    *band = NULL;
+
+    return S_FALSE;
 }
 
 static HRESULT WINAPI IDirectMusicStyle8Impl_EnumMotif(IDirectMusicStyle8 *iface, DWORD index,
-- 
2.25.0

[Michael Stefaniuc]

With the subject prefix changed to "dmstyle:"

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>



On 2/26/20 5:19 AM, Alistair Leslie-Hughes wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48648
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/dmstyle/style.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/dmstyle/style.c b/dlls/dmstyle/style.c
> index 3e480028b9e..5a97dac079a 100644
> --- a/dlls/dmstyle/style.c
> +++ b/dlls/dmstyle/style.c
> @@ -151,11 +151,17 @@ static HRESULT WINAPI IDirectMusicStyle8Impl_EnumBand(IDirectMusicStyle8 *iface,
>  }
>
> static HRESULT WINAPI IDirectMusicStyle8Impl_GetDefaultBand(IDirectMusicStyle8 *iface,
> -        IDirectMusicBand **ppBand)
> +        IDirectMusicBand **band)
>  {
> -        IDirectMusicStyle8Impl *This = impl_from_IDirectMusicStyle8(iface);
> -	FIXME("(%p, %p): stub\n", This, ppBand);
> -	return S_OK;
> +    IDirectMusicStyle8Impl *This = impl_from_IDirectMusicStyle8(iface);
> +    FIXME("(%p, %p): stub\n", This, band);
> +
> +    if (!band)
> +        return E_POINTER;
> +
> +    *band = NULL;
> +
> +    return S_FALSE;
>  }
>
> static HRESULT WINAPI IDirectMusicStyle8Impl_EnumMotif(IDirectMusicStyle8 *iface, DWORD index,