Re: gdi32: Improve the fontconfig filtering hack so that Mac suitcase fonts get through.
On Tue, 2006-12-19 at 21:21 +0000, Huw Davies wrote:
+ if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); Hi,
this patch was committed but I don't think this 'if' statement is correct as it will never be entered. No clue if it's just changing '&&' into '||'. Cheers, Paul.
On Wed, Dec 20, 2006 at 06:37:22PM +0100, Paul Vriens wrote:
On Tue, 2006-12-19 at 21:21 +0000, Huw Davies wrote:
+ if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); Hi,
this patch was committed but I don't think this 'if' statement is correct as it will never be entered.
Sure it will, if ext doesn't match "pfa" && ext doesn't match "pfb". Note that strcasecmp probably doesn't return what you think it does. Huw. -- Huw Davies huw(a)codeweavers.com
On Wed, 2006-12-20 at 17:59 +0000, Huw Davies wrote:
On Wed, Dec 20, 2006 at 06:37:22PM +0100, Paul Vriens wrote:
On Tue, 2006-12-19 at 21:21 +0000, Huw Davies wrote:
+ if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); Hi,
this patch was committed but I don't think this 'if' statement is correct as it will never be entered.
Sure it will, if ext doesn't match "pfa" && ext doesn't match "pfb". Note that strcasecmp probably doesn't return what you think it does.
Huw. My bad.
Sorry for the noise. Paul.
participants (2)
-
Huw Davies -
Paul Vriens