programs: add rudimentary dxdiag

[Louis. Lenders]

Hi, any comments on this one?
btw, is there a reason i never ever  receive any comments on my patches when they are rejected? If so, please tell me, that'll save me a lot of time of sending them in...


----- Forwarded Message ----
From: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk>
To: wine-patches(a)winehq.org
Sent: Thursday, 26 June, 2008 3:20:04 AM
Subject: Re: programs: add rudimentary dxdiag


Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for dxdiag.exe, and give an error if it's not found, so wine needs its own.
 Instead of simple stub, this patch also adds the (simplified)  d3d test like seen in native dxdiag, so users can test  if their d3d  is setup correctly. Screenshot can be seen here: http://bugs.winehq.org/attachment.cgi?id=14342

A few remarks:

-patch contains binary code for a bitmap, so to apply again i had to do
git apply dx.patch
git add programs/dxdiag/
tools/make_makefiles
autoconf
 
maybe there's a simpler way, but i dunno

- code for  spinning cube  was  partially based on  spinning cube code scattered all over the internet
-rest was ripped of winecfg
- There' s a problem while minizing the d3d-window, but running it in wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not a bug in the attached code. I'll go after that later.
- Hopefully you're not to picky on this patch, it 's quite some line's of code,and i'm sure things need to be improved, but this does not affect wine's core code but os rather an enhancement, and it 's not really possible to send it in in small chuncks.




________________________________
 Not happy with your email address? 
Get the one you  really want - millions of new email addresses available now at Yahoo!


      __________________________________________________________
Not happy with your email address?.
Get the one you really want - millions of new email addresses available now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html

[Juan Lang]

> Hi, any comments on this one?
> btw, is there a reason i never ever  receive any comments on my patches when
> they are rejected? If so, please tell me, that'll save me a lot of time of
> sending them in...

I'll bite.  One comment for both questions:  it's too big.  No comment
from AJ usually means either, "this is too big, I'll look at it
later," or "I think there's something wrong with it, but I don't know
what yet, I'll look at it later."  Of course new patches come along,
and you eventually get dropped from the queue.

You can split this up.  Try adding a stub program with one patch then
adding a bit at a time.
--Juan

[Austin English]

On Mon, Jun 30, 2008 at 9:50 AM, Louis. Lenders
<xerox_xerox2000(a)yahoo.co.uk> wrote:
> Hi, any comments on this one?
> btw, is there a reason i never ever  receive any comments on my patches when
> they are rejected? If so, please tell me, that'll save me a lot of time of
> sending them in...
>
> ----- Forwarded Message ----
> From: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk>
> To: wine-patches(a)winehq.org
> Sent: Thursday, 26 June, 2008 3:20:04 AM
> Subject: Re: programs: add rudimentary dxdiag
>
> Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for
> dxdiag.exe, and give an error if it's not found, so wine needs its own.
>  Instead of simple stub, this patch also adds the (simplified)  d3d test
> like seen in native dxdiag, so users can test  if their d3d  is setup
> correctly. Screenshot can be seen here:
> http://bugs.winehq.org/attachment.cgi?id=14342
>
> A few remarks:
>
> -patch contains binary code for a bitmap, so to apply again i had to do
> git apply dx.patch
> git add programs/dxdiag/
> tools/make_makefiles
> autoconf
>
> maybe there's a simpler way, but i dunno
>
> - code for  spinning cube  was  partially based on  spinning cube code
> scattered all over the internet
> -rest was ripped of winecfg
> - There' s a problem while minizing the d3d-window, but running it in
> wine-0.9.22 it all goes fine, so this must be a regression somewhere, and
> not a bug in the attached code. I'll go after that later.
> - Hopefully you're not to picky on this patch, it 's quite some line's of
> code,and i'm sure things need to be improved, but this does not affect
> wine's core code but os rather an enhancement, and it 's not really possible
> to send it in in small chuncks.
>
> ________________________________
> Not happy with your email address?
> Get the one you really want - millions of new email addresses available now
> at Yahoo!
> ________________________________
> Not happy with your email address?
> Get the one you really want - millions of new email addresses available now
> at Yahoo!

Like I said in the bug, you should add dxdiag to configure.ac/Makefile.in/etc.

-Austin

[Detlef Riekenberg]

On Mo, 2008-06-30 at 10:15 -0500, Austin English wrote:
> > Instead of simple stub, this patch also adds the (simplified)  d3d test
> > like seen in native dxdiag, so users can test  if their d3d  is setup
> > correctly. Screenshot can be seen here:
> > http://bugs.winehq.org/attachment.cgi?id=14342

It looks nice, but the Patch is very large!
> > and it 's not really possible
> > to send it in in small chuncks.

Why not?
- empty stub
- the property-sheet
- demo-window with an empty (in memory) Bitmap
- the wine-logo as bitmap
- spinning cube
reorder, when needed
> Like I said in the bug, you should add dxdiag to
> configure.ac/Makefile.in/etc.
>
> -Austin

No, Louis used the correct way: 
tools/make_makefiles
./autoconf



-- 
 
By by ... Detlef

[Louis Lenders]

Detlef Riekenberg <wine.dev <at> web.de> writes:
> Why not?
> - empty stub
> - the property-sheet
> - demo-window with an empty (in memory) Bitmap
> - the wine-logo as bitmap
> - spinning cube
> reorder, when needed

Hi Detlef (and Juan) , thanks for the response. I sent in a simple stub (and two
other patches on top of that i need to get something useful in dxdiag) but
apparently they are not accepted either. If only i knew why, but i don't as
again  i got no comment why they were rejected, so for now i'd have to guess :
1. no need for a dxdiag in wine
2. my patches are too crappy to respond to.

In both cases it's useless to leave thebug i  opened for missing dxdiag  open,
so i'll abandon it (bug 14118)

[Juan Lang]

Hi Louis,
> Hi Detlef (and Juan) , thanks for the response. I sent in a simple stub (and two
> other patches on top of that i need to get something useful in dxdiag) but
> apparently they are not accepted either.

Apparently they were never received in the first place.  At least, I
don't see them on the wine-patches archive.  Maybe you should resend?
--Juan

[Louis Lenders]

Juan Lang <juan.lang <at> gmail.com> writes:
> Hi Louis,

> Apparently they were never received in the first place.  At least, I
> don't see them on the wine-patches archive.  Maybe you should resend?
> --Juan

Hi Juan: 
http://www.winehq.org/pipermail/wine-patches/2008-June/056911.html

[Juan Lang]

> http://www.winehq.org/pipermail/wine-patches/2008-June/056911.html

Ah.  That's not enough to judge where your patches are going.  A
series of patches, adding a stub program, then adding a little more to
it, and so on, would help judge the final product, while considering
each piece independently.  It has the risk of getting rejected partway
or wholesale, but has a higher likelihood of getting comments.  It
also removes a lot of the roundtrip time with patches.

Sorry if the guidance isn't very clear.  Don't be afraid to ask AJ on
irc for more feedback too.
--Juan

[Louis Lenders]

Juan Lang <juan.lang <at> gmail.com> writes:
> > http://www.winehq.org/pipermail/wine-patches/2008-June/056911.html
>
> Ah.  That's not enough to judge where your patches are going.

I already explained, see http://bugs.winehq.org/attachment.cgi?id=14342 and
http://www.winehq.org/pipermail/wine-patches/2008-June/056659.html. That's what
i was intended to go to.

 A
> series of patches, adding a stub program, then adding a little more to
> it, and so on, would help judge the final product, while considering
> each piece independently.

Here;s the whole patch that i sent a while ago, but i was advised after that to
first sent a simple stub because the patch was too large:

http://bugs.winehq.org/attachment.cgi?id=14343


It has the risk of getting rejected partway
> or wholesale, but has a higher likelihood of getting comments.  It
> also removes a lot of the roundtrip time with patches.
>
> Sorry if the guidance isn't very clear.  Don't be afraid to ask AJ on
> irc for more feedback too.
> --Juan

Anyway. thanks for your explanation

[Juan Lang]

> I already explained, see http://bugs.winehq.org/attachment.cgi?id=14342 and
> http://www.winehq.org/pipermail/wine-patches/2008-June/056659.html. That's what
> i was intended to go to.

Yes, but such a large patch is hard to read.  See e.g. how I submitted
inetmib1.dll, beginning here:
http://www.winehq.org/pipermail/wine-patches/2008-June/056352.html

Rather than sending it in one patch, or then one patch at a time, I
sent the DLL broken up into many individual patches, all at one time
so they could be reviewed both individually and as a whole.  Some made
it, some were rejected.  I also had to ask for feedback, I didn't get
any until I asked.

Patience...
--Juan

[Jeff Zaroyko]

On Thu, Jul 3, 2008 at 9:27 AM, Louis Lenders
<xerox_xerox2000(a)yahoo.co.uk> wrote:
> Juan Lang <juan.lang <at> gmail.com> writes:
> > > http://www.winehq.org/pipermail/wine-patches/2008-June/056911.html
> >
> > Ah.  That's not enough to judge where your patches are going.
>
> I already explained, see http://bugs.winehq.org/attachment.cgi?id=14342 and
> http://www.winehq.org/pipermail/wine-patches/2008-June/056659.html. That's what
> i was intended to go to.
>
> A
> > series of patches, adding a stub program, then adding a little more to
> > it, and so on, would help judge the final product, while considering
> > each piece independently.
>
> Here;s the whole patch that i sent a while ago, but i was advised after that to
> first sent a simple stub because the patch was too large:
>
> http://bugs.winehq.org/attachment.cgi?id=14343
>
> It has the risk of getting rejected partway
> > or wholesale, but has a higher likelihood of getting comments.  It
> > also removes a lot of the roundtrip time with patches.
> >
> > Sorry if the guidance isn't very clear.  Don't be afraid to ask AJ on
> > irc for more feedback too.
> > --Juan
>
> Anyway. thanks for your explanation

You might also consider generating your patches using `git
format-patch --keep-subject origin` as per
http://www.winehq.org/site/sending_patches and sending your mail in
plain text, not html.

[Alexandre Julliard]

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes:
> Here;s the whole patch that i sent a while ago, but i was advised after that to
> first sent a simple stub because the patch was too large:
>
> http://bugs.winehq.org/attachment.cgi?id=14343

Here's what you said in your original patch:
> - code for  spinning cube  was  partially based on  spinning cube code scattered all over the internet
> -rest was ripped of winecfg
> - There' s a problem while minizing the d3d-window, but running it in wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not a bug in the attached code. I'll go after that later.
> - Hopefully you're not to picky on this patch, it 's quite some line's of code,and i'm sure things need to be improved, but this does not affect wine's core code but os rather an enhancement, and it 's not really possible to send it in in small chuncks.

Basically you copied code from you don't know where, minimizing doesn't
work but that's not a bug, and I shouldn't be picky and accept a big
crappy patch anyway. Do you really wonder why you have trouble getting
it committed?

-- 
Alexandre Julliard
julliard(a)winehq.org

[Louis Lenders]

> Here's what you said in your original patch:
> > - code for  spinning cube  was  partially based on  spinning cube code
> > scattered all over the internet
> > -rest was ripped of winecfg
> > - There' s a problem while minizing the d3d-window, but running it in
> > wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not
> > a >>bug in the attached code. I'll go after that later.
> > - Hopefully you're not to picky on this patch, it 's quite some line's of
> > code,and i'm sure things need to be improved, but this does not affect wine's
> > core code but os rather an enhancement, and it 's not really possible to send
> > it >>in in small chuncks.
> Basically you copied code from you don't know where,
> True, why reinvent the wheel (copied code from winecfg)
> minimizing doesn't work but that's not a bug, 
> as far as i can see it looks like regression
> and I shouldn't be picky and accept a big crappy patch anyway. 
> I admit i'm just a hobbiest, but somehow i was hoping you could point me to what
> the "crappy" parts in the patch are, so that i could improve it, but i already
> gave up that hope.
> Do you really wonder why you have trouble getting it committed?
> Maybe i was just hoping for some positive feedback, but i'll stop wasting yours
> and my time

[Detlef Riekenberg]

On Mi, 2008-07-02 at 23:02 +0000, Louis Lenders wrote:
> so for now i'd have to guess :
> 1. no need for a dxdiag in wine
> 2. my patches are too crappy to respond to.
>
> In both cases it's useless to leave thebug i  opened for missing dxdiag  open,
> so i'll abandon it (bug 14118)

Louis, please do not give up and reopen the bug.
You got already some comments, and I want to give some more Ideas.

- You told, that you reuse the code for the cube from the internet.
  That is a no-go because of copyright and license issues!
  Where does the code came from?
  What is the license for that code?
  - Remember, that Wine is "LGPL v2.1 or later". 
  - You can't use GPL code (That would force Wine to GPL)
  - You can't use LGPL v3 code (That would force Wine to LGPL v3)
  The code works, as show in your demonstration, but IMHO the best thing
  is to use the math. formula with a clean implementation from scratch.
  - Multiple backends with support for different color-depth
    should then be possible: OpenGL, GDI, DX7, DX8, DX9.

- You told, that minimizing the Cube-Window does not work now,
  but worked in an old Wine.
  You think, that this is an Regression in Wine.
  It's also possible, that there was an bug in Wine which is now fixed 
  and your dxdiag code is not correct.
  Only a Regression-Test can help for this issue.
  Again, a clean implementation can avoid this issue.

Thanks for helping Wine


-- 
 
By by ... Detlef

[Louis Lenders]

Detlef Riekenberg <wine.dev <at> web.de> writes:
>

> Louis, please do not give up and reopen the bug.
> You got already some comments, and I want to give some more Ideas.
>
> - You told, that you reuse the code for the cube from the internet.
>   That is a no-go because of copyright and license issues!
>   Where does the code came from?
>   What is the license for that code?

As already said, from tutorials scattered allover the internet,
www.codesampler for example. I'm not sure what the license code 
for a tutorial is. Is the "hello world" tutorial also copyrighted?
> - You told, that minimizing the Cube-Window does not work now,
>   but worked in an old Wine.
>   You think, that this is an Regression in Wine.
>   It's also possible, that there was an bug in Wine which is now fixed 
>   and your dxdiag code is not correct.

I'd have to check by compiling a windows executable. If it runs 
in windows, it should run in wine.
> Again, a clean implementation can avoid this issue.

As long as simple stub is not accepted i cannot even start with that. Anyway,
thanks for your comments Detlef. Regards

[Matt 'Murph' Finnicum]

> From http://www.codesampler.com/disclaimer.htm:

"Kevin R. Harris retains all ownership rights to all documents
(including but not limited to image, html, text files, and archived
source code) on "the Web Site" (www.CodeSampler.com). Use of the Web
Site is governed by applicable copyright law. " ... "The user may not
reuse or publish any of the documents on the Web Site without the
express written permission of Kevin R. Harris."

Obviously, code taken from that site can't be used in Wine without the
express written permission of it's author.

On Tue, Jul 8, 2008 at 7:59 AM, Louis Lenders
<xerox_xerox2000(a)yahoo.co.uk> wrote:
> Detlef Riekenberg <wine.dev <at> web.de> writes:
> >
> > Louis, please do not give up and reopen the bug.
> > You got already some comments, and I want to give some more Ideas.
> >
> > - You told, that you reuse the code for the cube from the internet.
> >   That is a no-go because of copyright and license issues!
> >   Where does the code came from?
> >   What is the license for that code?
>
> As already said, from tutorials scattered allover the internet,
> www.codesampler for example. I'm not sure what the license code
> for a tutorial is. Is the "hello world" tutorial also copyrighted?
> > - You told, that minimizing the Cube-Window does not work now,
> >   but worked in an old Wine.
> >   You think, that this is an Regression in Wine.
> >   It's also possible, that there was an bug in Wine which is now fixed
> >   and your dxdiag code is not correct.
>
> I'd have to check by compiling a windows executable. If it runs
> in windows, it should run in wine.
> > Again, a clean implementation can avoid this issue.
>
> As long as simple stub is not accepted i cannot even start with that. Anyway,
> thanks for your comments Detlef. Regards