Re: [PATCH 1/5] ddraw/tests: Remove A4R4G4B4 ckey tests (v2).
On 5 June 2016 at 23:56, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
They're more broken on Nvidia + Win10 than they used to be on Nvidia + Win7. I can't find a way to detect the problem without putting the driver into a broken state.
The annoying part of this is that we lose 4 bit precision tests. X4R4G4B4 doesn't seem to exist everywhere. --- I don't suppose there's any chance of getting the driver fixed. Would something along the lines of adapter_is_warp() work here perhaps? With recent Windows versions, I'm getting the impression that there may come a point where we'll have a maximum version to run the ddraw tests on.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-07 um 16:18 schrieb Henri Verbeet:
I don't suppose there's any chance of getting the driver fixed. Would something along the lines of adapter_is_warp() work here perhaps? With recent Windows versions, I'm getting the impression that there may come a point where we'll have a maximum version to run the ddraw tests on. WARP isn't so much a problem here - it only returns junk data. The Nvidia driver is the bigger problem here because the test gets stuck forever.
Are you suggesting to try to get Nvidia to fix their drivers? I'd rather not spend time on this. Detecting the nvidia driver in advance and skipping this test based on that similar to adapter_is_warp is something I'd be open to though. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXVyC2AAoJEN0/YqbEcdMwwQ0P/3gXe9h7fLdK1+XmiKx9j7ce NakbHIcB4vu50IKHyTMULCaxZEg+qV5KxTeI4zNNV47aWyAgMCebb1CTkKGqc1tP YfpSvpxDDGYIDV8TdLoJCVTtp1CCTwgoCGQce4dsa3zYmSM5SH8YX5sLvA4CAxFc 7iGL5h2tTXjpxbp0VSefwgVGOSDA2Du9e6bP41xvec0jZ+oJUEm+WMtIFVxxqUVl cz6A0f64o81mS3MF43a/MUSMIAGi5u4FXxplboFM+5URUlJeTOPv1UhN7iJFsLlw LmBlUvzWog2RzAt1AaeKcrLUXdUPFxzol5FUIJT8O188XFdVdmutbHtXJOFCpmY9 4/Nlos1yeQg5aaIw7oM8wEJmXqBFz5agKJrwZJYRaIa9LHmVpR5qMSBGQW/ixFsL OeAP0pecO/Iysj/Y9zpC03fdzJ9raDDJ8LlH8bxu+THKLdzE9Q7ciDbG6ptfboT7 Sx5GjxyWiPMxMuxYi43TjxuD5eC2N2gmRVWeNFJ6Cgkn4BNyI02yJfay22in8ePZ XOaw2t92Sbu6CcLrivXerPWaMG9oJZgFK2ilUWwGTBTnDYA83srP1d/2FRcIQhaM dHdErS5W6LzLJT+Mwcyrs18R1+zdnoq7CuWPofUwuggxym3YGWMyXJHnrBqu7RW9 VeV31op86dwS8zDYBC+C =nD15 -----END PGP SIGNATURE-----
On 7 June 2016 at 21:29, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Are you suggesting to try to get Nvidia to fix their drivers? I'd Ideally, but it's one of those low-probability things.
rather not spend time on this. Detecting the nvidia driver in advance and skipping this test based on that similar to adapter_is_warp is something I'd be open to though. Yeah, I think that's better than disabling the test everywhere, if only marginally. You'll probably want to take "winetest_platform" into account in addition to the driver name.
participants (2)
-
Henri Verbeet -
Stefan Dösinger