[PATCH] oleaut32: Cut off only non-empty \[0-9]+$ resource-id in RegisterTypeLib.

[Jacek Caban]

From: Puetz Kevin A <PuetzKevinA(a)JohnDeere.com>

Check if szFullPath ended with '\\' (was explicitly a directory).

Signed-off-by: Kevin Puetz <PuetzKevinA(a)JohnDeere.com>
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/oleaut32/typelib.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

[Puetz Kevin A]

Thanks. I take it you prefer commit messages to be briefer and worded for "how it works now", with less discussion of "what was wrong with the previous behavior". Or at least move that explanatory under the --- separator that ends the git commit message. I'll try and follow that for the rest of the submissions I'm preparing...

Do I need to do something to retract my original patch from the queue at https://source.winehq.org/patches/ (it isn't showing as Superseded like I usually see when there is a v2 patch)? If so, how do I do that? https://wiki.winehq.org/Submitting_Patches doesn't seem to say...
> -----Original Message-----
> From: wine-devel <wine-devel-bounces(a)winehq.org> On Behalf Of Jacek
> Caban
> Sent: Thursday, July 16, 2020 2:06 PM
> To: wine-devel <wine-devel(a)winehq.org>
> Subject: [PATCH] oleaut32: Cut off only non-empty \[0-9]+$ resource-id in
> RegisterTypeLib.
>
> From: Puetz Kevin A <PuetzKevinA(a)JohnDeere.com>
>
> Check if szFullPath ended with '\\' (was explicitly a directory).
>
> Signed-off-by: Kevin Puetz <PuetzKevinA(a)JohnDeere.com>
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
>   dlls/oleaut32/typelib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[Jacek Caban]

On 16.07.2020 21:42, Puetz Kevin A wrote:
> Thanks. I take it you prefer commit messages to be briefer and worded for "how it works now", with less discussion of "what was wrong with the previous behavior". Or at least move that explanatory under the --- separator that ends the git commit message. I'll try and follow that for the rest of the submissions I'm preparing...

The main part of commit messages are somewhat standardized in Wine. It's 
not very strict, git log should give you a good idea how it looks.

Commit comments are really up to you, but in general it's good to have 
them not too long. It's usually not a big deal, Alexandre cuts them 
sometimes himself when doing commits. Putting additional informations 
useful for reviewer but not meant for changelog after --- helps with it.
> Do I need to do something to retract my original patch from the queue at https://source.winehq.org/patches/ (it isn't showing as Superseded like I usually see when there is a v2 patch)? If so, how do I do that? https://wiki.winehq.org/Submitting_Patches doesn't seem to say...

They will be marked as superseded when Alexandre pushes commits.


Thanks,

Jacek