Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

[Dan Kegel]

2011/9/18 Dan Kegel <dank(a)kegel.com>:
> Don't let this one languish - it makes a huge difference for me!

I should mention: with your latest additions to the cmd tests,
time to run the cmd tests is starting to go off the cliff,
and is now above four minutes... but with your efficiency
patch, it only takes four seconds.

[PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

[Frédéric Delanoy]

2011/9/18 Dan Kegel <dank(a)kegel.com>:
> 2011/9/18 Dan Kegel <dank(a)kegel.com>:
> > Don't let this one languish - it makes a huge difference for me!
>
> I should mention: with your latest additions to the cmd tests,
> time to run the cmd tests is starting to go off the cliff,
> and is now above four minutes... but with your efficiency
> patch, it only takes four seconds.

Sent a cleaned up version (try 3)
Not sure AJ will accept it though, since it seems he wanted a "batch
file reading method" overhaul first.

Frédéric

[PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

[Octavian Voicu]

2011/9/18 Dan Kegel <dank(a)kegel.com>:
> 2011/9/18 Dan Kegel <dank(a)kegel.com>:
> > Don't let this one languish - it makes a huge difference for me!
>
> I should mention: with your latest additions to the cmd tests,
> time to run the cmd tests is starting to go off the cliff,
> and is now above four minutes... but with your efficiency
> patch, it only takes four seconds.

I have a quick fix for you, which did wonders for me. Initially I also
had timeouts on every test, now they all pass. The ideas is to run the
tests from an empty directory. The commands that recurse into
subdirectories run much faster if they don't have a lot of
subdirectories to search.

Of course, the label cache patch seems to do even more wonders :)

Octavian