Re: winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 4)

[Vitaliy Margolen]

Vitaliy Margolen wrote:
> This time with lots of tests that exposed number of other problems that 
> were fixed.
>
> I could not separate this patch into separate pieces - they all linked 
> together and
> fixing one problem meant fixing or breaking something else. This 
> especially related
> to the tests that test everything together as a one black box.
>
> There are still few problems remain that could be exposed by tightening 
> tests.
> ---

Anything wrong with this patch?
Vitaliy

winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 4)

[Alexandre Julliard]

Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
> Anything wrong with this patch?

The message patching inside peek_message looks very wrong, I have a hard
time believing that this is really where this should happen. It most
likely belongs somewhere like process_keyboard_message.

-- 
Alexandre Julliard
julliard(a)winehq.org

winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 4)

[Vitaliy Margolen]

Alexandre Julliard wrote:
> Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
> > Anything wrong with this patch?
>
> The message patching inside peek_message looks very wrong, I have a hard
> time believing that this is really where this should happen. It most
> likely belongs somewhere like process_keyboard_message.

Thank you. I wasn't sure where it should go myself. The 
process_keyboard_message is the last in the chain place it can go in. Some 
simple tests showed that journal hook gets the normal VK_SHIFT not 
left/right shift.