Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

[Nikolay Sivov]

On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote:
> ---
>   dlls/ntdll/tests/file.c | 41 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 41 insertions(+)
>
> diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
> index 120fdac..5ae605b 100644
> --- a/dlls/ntdll/tests/file.c
> +++ b/dlls/ntdll/tests/file.c
> @@ -1985,6 +1985,22 @@ static void test_read_write(void)
>
> bytes = 0xdeadbeef;
>       SetLastError(0xdeadbeef);
> +    ret = ReadFile(INVALID_HANDLE_VALUE, buf, 0,&bytes, NULL);
> +todo_wine
> +    ok(!ret, "ReadFile should fail\n");
> +todo_wine
> +    ok(GetLastError() == ERROR_INVALID_HANDLE, "expected ERROR_INVALID_HANDLE, got %d\n", GetLastError());
> +    ok(bytes == 0, "bytes %u\n", bytes);

That's again a test for kernel32 calls, placed in a wrong file.

[1/4] ntdll/tests: Add 0-length read tests for a disk file.

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > --- a/dlls/ntdll/tests/file.c
> > +++ b/dlls/ntdll/tests/file.c
> > @@ -1985,6 +1985,22 @@ static void test_read_write(void)
> >
> > bytes = 0xdeadbeef;
> >       SetLastError(0xdeadbeef);
> > +    ret = ReadFile(INVALID_HANDLE_VALUE, buf, 0,&bytes, NULL);
> > +todo_wine
> > +    ok(!ret, "ReadFile should fail\n");
> > +todo_wine
> > +    ok(GetLastError() == ERROR_INVALID_HANDLE, "expected ERROR_INVALID_HANDLE, got %d\n", GetLastError());
> > +    ok(bytes == 0, "bytes %u\n", bytes);
>
> That's again a test for kernel32 calls, placed in a wrong file.

Please actually look at the tests before commenting.

-- 
Dmitry.