Re: winspool/tests: [1/3] Tests for GetPrintProcessorDirectory

[Alexandre Julliard]

Detlef Riekenberg <wine.dev(a)web.de> writes:
> +    SetLastError(0xdeadbeef);
> +    res = GetPrintProcessorDirectoryA(NULL, NULL, 1, NULL, 0, &cbBuf);
> +    if(!res && ( (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) ||
> +                 (GetLastError() == 0xdeadbeef) )) {
> +        trace("Not implemented yet\n");
> +        return;
> +    }

Unless there really is a Windows version that fails here, this test is
wrong. Things that are not implemented yet in Wine should be marked
with todo_wine, not ignored.

-- 
Alexandre Julliard
julliard(a)winehq.org

winspool/tests: [1/3] Tests for GetPrintProcessorDirectory

[Detlef Riekenberg]

Am Donnerstag, den 01.06.2006, 11:15 +0200 schrieb Alexandre Julliard:
> Detlef Riekenberg <wine.dev(a)web.de> writes:
> > +    SetLastError(0xdeadbeef);
> > +    res = GetPrintProcessorDirectoryA(NULL, NULL, 1, NULL, 0, &cbBuf);
> > +    if(!res && ( (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) ||
> > +                 (GetLastError() == 0xdeadbeef) )) {
> > +        trace("Not implemented yet\n");
> > +        return;
> > +    }
>
> Unless there really is a Windows version that fails here, this test is
> wrong. Things that are not implemented yet in Wine should be marked
> with todo_wine, not ignored.

Our current stub is just a FIXME, followed by "return 0".
The missing "SetLastError()" is detected by
"GetLastError() == 0xdeadbeef"

I see no reason to run the rest of the tests for our stub or add a
"SetLastError(ERROR_CALL_NOT_IMPLEMENTED)", that needs to be removed by
the next Patch.


ReactOS has SetLastError(ERROR_CALL_NOT_IMPLEMENTED) in every stub.

I want to be nice to make it easy for them to reuse our tests.
They got an SoC-Project for the Spooler, so the lifetime for this 
test will be about half a Year up to the maximum of a Year.

I can document in the wiki or in the Source the location for such Code,
that is not needed for Wine any longer but temporary still in Wine to
allow ReactOS to reuse our Code more effective.


-- 
By By ...
      ... Detlef

winspool/tests: [1/3] Tests for GetPrintProcessorDirectory

[Alexandre Julliard]

Detlef Riekenberg <wine.dev(a)web.de> writes:
> I want to be nice to make it easy for them to reuse our tests.
> They got an SoC-Project for the Spooler, so the lifetime for this 
> test will be about half a Year up to the maximum of a Year.

Nobody will ever fix it, since it silently handles both cases.
> I can document in the wiki or in the Source the location for such Code,
> that is not needed for Wine any longer but temporary still in Wine to
> allow ReactOS to reuse our Code more effective.

The tests are supposed to reflect the Windows behavior, not the Wine
or Reactos behavior. Unless Windows returns ERROR_CALL_NOT_IMPLEMENTED
here, it's not correct for Wine to do it, and that's what the test
should express by using a todo_wine.

-- 
Alexandre Julliard
julliard(a)winehq.org