Re: version resource for ole2nls.dll

[Dmitry Timoshkov]

"Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote:
> This patch fixes Bug 9747
>
> ChangeLog
> ---------
> added version resource for ole2nls.dll
> +#define WINE_FILEVERSION_STR "2.10.3050.1"
> +#define WINE_FILEDESCRIPTION_STR "Wine OLE dll"
> +#define WINE_FILENAME_STR "OLE2NLS.DLL"
> +
> +#include "wine/wine_common_ver.rc"

Why do you define WINE_FILEVERSION_STR but not WINE_FILEVERSION?
That not creates a confusion but could lead to hard debuggable
problems with application which test only one of them.

-- 
Dmitry.

version resource for ole2nls.dll

[Dmitry Timoshkov]

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote:
> "Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote:
> > This patch fixes Bug 9747
> >
> > ChangeLog
> > ---------
> > added version resource for ole2nls.dll
> > +#define WINE_FILEVERSION_STR "2.10.3050.1"
> > +#define WINE_FILEDESCRIPTION_STR "Wine OLE dll"
> > +#define WINE_FILENAME_STR "OLE2NLS.DLL"
> > +
> > +#include "wine/wine_common_ver.rc"
>
> Why do you define WINE_FILEVERSION_STR but not WINE_FILEVERSION?
> That not creates a confusion but could lead to hard debuggable
> problems with application which test only one of them.

The above should be read as:

That not only creates a confusion but could lead to hard debuggable
problems with application which test only one of them.

-- 
Dmitry.