[PATCH v3 2/7] ntdll: Provide some Unicode helpers for Unix libs.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/ntdll/unix/env.c | 98 ++++++++++++++++++++++++++++++-------------
  1 file changed, 69 insertions(+), 29 deletions(-)

[Huw Davies]

On Wed, Oct 06, 2021 at 12:57:04PM +0200, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
>  dlls/ntdll/unix/env.c | 98 ++++++++++++++++++++++++++++++-------------
>  1 file changed, 69 insertions(+), 29 deletions(-)

Hi Jacek,

This is giving me random crashes on (32-bit) macOS, e.g.:

tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush && touch dlls/gdi32/tests/brush.ok
/bin/sh: line 1: 59187 Segmentation fault: 11  tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush

Huw.

[Jacek Caban]

Hi Huw,

On 06/10/2021 15:12, Huw Davies wrote:
> On Wed, Oct 06, 2021 at 12:57:04PM +0200, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > ---
> >   dlls/ntdll/unix/env.c | 98 ++++++++++++++++++++++++++++++-------------
> >   1 file changed, 69 insertions(+), 29 deletions(-)
> > Hi Jacek,
>
> This is giving me random crashes on (32-bit) macOS, e.g.:
>
> tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush && touch dlls/gdi32/tests/brush.ok
> /bin/sh: line 1: 59187 Segmentation fault: 11  tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush

I think I can see the problem, the attached patch should help. I will do 
more testing and send an updated patch.


Thanks,

Jacek

[Huw Davies]

On Wed, Oct 06, 2021 at 03:53:53PM +0200, Jacek Caban wrote:
> Hi Huw,
>
> On 06/10/2021 15:12, Huw Davies wrote:
> > On Wed, Oct 06, 2021 at 12:57:04PM +0200, Jacek Caban wrote:
> > > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > > ---
> > >   dlls/ntdll/unix/env.c | 98 ++++++++++++++++++++++++++++++-------------
> > >   1 file changed, 69 insertions(+), 29 deletions(-)
> > > Hi Jacek,
> >
> > This is giving me random crashes on (32-bit) macOS, e.g.:
> >
> > tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush && touch dlls/gdi32/tests/brush.ok
> > /bin/sh: line 1: 59187 Segmentation fault: 11  tools/runtest -q -P wine -T . -M gdi32.dll -p dlls/gdi32/tests/gdi32_test.exe brush
>
> I think I can see the problem, the attached patch should help. I will do
> more testing and send an updated patch.

Hi Jacek,

Yes, that seems to fix it.

Thanks,
Huw.