[PATCH] mshtml: Remove WINAPI on static functions where not needed.

[Francois Gouget]

Signed-off-by: Francois Gouget <fgouget(a)free.fr>
---
This used to be needed on macOS due to some compiler issue but I'm not 
sure if that's still the case.
Let me know if this type of patch is not desired anymore.
---
 dlls/mshtml/htmlelem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c
index 9ad538d2b00..d9554f4668d 100644
--- a/dlls/mshtml/htmlelem.c
+++ b/dlls/mshtml/htmlelem.c
@@ -6515,7 +6515,7 @@ static const WCHAR *find_token(const WCHAR *list, const WCHAR *token, unsigned i
     return NULL;
 }
 
-static HRESULT WINAPI token_list_add_remove(IWineDOMTokenList *iface, BSTR token, BOOL remove)
+static HRESULT token_list_add_remove(IWineDOMTokenList *iface, BSTR token, BOOL remove)
 {
     struct token_list *token_list = impl_from_IWineDOMTokenList(iface);
     unsigned int i, len, old_len, new_len;
-- 
2.20.1

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

On 8/27/21 12:47 PM, Francois Gouget wrote:
> Signed-off-by: Francois Gouget <fgouget(a)free.fr>
> ---
> This used to be needed on macOS due to some compiler issue but I'm not
> sure if that's still the case.
> Let me know if this type of patch is not desired anymore.

I don't think it's needed for macOS any more, but I think it's a good 
idea to skip explicit calling convention when it's not needed anyway.


Thanks,

Jacek

[Francois Gouget]

On Fri, 27 Aug 2021, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
>
> On 8/27/21 12:47 PM, Francois Gouget wrote:
> > Signed-off-by: Francois Gouget <fgouget(a)free.fr>
> > ---
> > This used to be needed on macOS due to some compiler issue but I'm not
> > sure if that's still the case.
> > Let me know if this type of patch is not desired anymore.
>
> I don't think it's needed for macOS any more, but I think it's a good idea to
> skip explicit calling convention when it's not needed anyway.

Should that also apply to things like static CDECL?


-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
           If it stinks, it's chemistry. If it moves, it's biology.
                  If it does not work, it's computer science.

[Jacek Caban]

On 8/27/21 3:09 PM, Francois Gouget wrote:
> On Fri, 27 Aug 2021, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> >
> > On 8/27/21 12:47 PM, Francois Gouget wrote:
> > > Signed-off-by: Francois Gouget <fgouget(a)free.fr>
> > > ---
> > > This used to be needed on macOS due to some compiler issue but I'm not
> > > sure if that's still the case.
> > > Let me know if this type of patch is not desired anymore.
> > > I don't think it's needed for macOS any more, but I think it's a good idea to
> > > skip explicit calling convention when it's not needed anyway.
> > > Should that also apply to things like static CDECL?

Yes, I think that it's better to avoid CDECL in those cases as well.


Thanks,

Jacek