SMATCH: Returning with freed result
Hello, this was found by unfree-wine.pl a slight modification of smatch's unfree.pl. The first occurence was easy to fix (see attachment) but i don't know what should be done in this case: dlls/ole32/filemoniker.c 1084 1086 FileMonikerImpl_CommonPrefixWith(75) Returning with freed result var_decl(commonPath) This is due to this code: HeapFree(GetProcessHeap(),0,commonPath); return CreateFileMoniker(commonPath,ppmkPrefix); I would save the return of CreateFileMoniker to a temp variable and after that free commonPath but i don't know if it's the desired fix. License: LGPL, X11 Changelog: Michael Stefaniuc <mstefani(a)redhat.com> - fix for return of a previous freed object bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart
participants (1)
-
Michael Stefaniuc