Re: (Try2) wininet/tests: Fix HttpSendRequestW test on Win2k platform.
On Monday 20 April 2009 20:14:14 Nicolas Le Cam wrote:
Win2k SP4 seems to be the only platform that follows what msdn says (see http://msdn.microsoft.com/en-us/library/aa384247(VS.85).aspx).
wininet is bundled with Internet Explorer, so it's more useful to look at the Explorer version than the Windows version.
Perhaps passing header's length to HttpSendRequest instead of adding a broken expected value would be better. Let me know.
No, the length parameter is the essence of this test. I wrote it because I saw IE7 call HttpSendRequestW like this which contradicts MSDN. The test shows that MSDN is outdated; on recent wininet HttpSendRequestW will calculate the header length for you. -Hans
2009/4/20 Hans Leidekker <hans(a)codeweavers.com>:
On Monday 20 April 2009 20:14:14 Nicolas Le Cam wrote:
Win2k SP4 seems to be the only platform that follows what msdn says (see http://msdn.microsoft.com/en-us/library/aa384247(VS.85).aspx).
wininet is bundled with Internet Explorer, so it's more useful to look at the Explorer version than the Windows version.
Perhaps passing header's length to HttpSendRequest instead of adding a broken expected value would be better. Let me know.
No, the length parameter is the essence of this test. I wrote it because I saw IE7 call HttpSendRequestW like this which contradicts MSDN. The test shows that MSDN is outdated; on recent wininet HttpSendRequestW will calculate the header length for you.
-Hans
As I didn't get any comments for my previous patch neither on wine-devel nor on IRC I did thought my remark was the right way to go. This is wininet 5.0.3700.6713. I will resend making this test broken on IE 5.01. Thanks for review. -- Nicolas Le Cam
participants (2)
-
Hans Leidekker -
Nicolas Le Cam