Re: [PATCH] crypt32/tests: Fix a memory leak in testFindCRL.
On Sun, Feb 26, 2017 at 11:52 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
... + store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0, + CERT_STORE_CREATE_NEW_FLAG, NULL); + if (!store) return; + ...
Would you mind adding an error when this happens? Otherwise we may not know that these tests did not run. Best, Erich
2017-03-07 7:03 GMT-07:00 Erich E. Hoover <erich.e.hoover(a)wine-staging.com>:
On Sun, Feb 26, 2017 at 11:52 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
... + store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0, + CERT_STORE_CREATE_NEW_FLAG, NULL); + if (!store) return; + ...
Would you mind adding an error when this happens? Otherwise we may not know that these tests did not run.
Sure. Should that be a win_skip statement or an ok statement? Is there ever a case when we expect CertOpenStore to fail? -Alex
On Tue, Mar 7, 2017 at 10:38 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
... Sure. Should that be a win_skip statement or an ok statement? Is there ever a case when we expect CertOpenStore to fail?
I think an ok(store!=NULL, ...) would be best, just in case it fails on the build bot. There are other places in the tests where the message implies that the store fails to open due to insufficient permissions. Best, Erich
participants (2)
-
Alex Henrie -
Erich E. Hoover