Re: dplay: directplay should initialize session Guid patch +conformance tests

[Dmitry Timoshkov]

"Alessandro Pignotti" <alex.pigna(a)inventati.org> wrote:
> +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection,
> + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags, 
> + LPVOID lpContext)
> +{

This doesn't look like a proper type of callb ack for IDirectPlayX_EnumConnections.
> +  bzero(&sessionDesc,sizeof(DPSESSIONDESC2));
> +  bzero(&zeroGuid,16);

Use memset instead of non-portable bzero.
> + LPDIRECTPLAY4 pDP = NULL;

This initialization is redundant.

If you also could use 4 spaces indents instead of tabs, and add an empty line
after data declarations that would be nice as well.

And a personal opinion: all that lines without a single space delimiting
variables, functions, equal signs are absolutely not readable.

-- 
Dmitry.

dplay: directplay should initialize session Guid patch +conformance tests

[H. Verbeet]

On 27/02/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
> > +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection,
> > + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags,
> > + LPVOID lpContext)
> > +{
>
> This doesn't look like a proper type of callb ack for IDirectPlayX_EnumConnections.

I wondered about that as well, but it does appear to be what the DXSDK
headers specify.