Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

[Paul Vriens]

On 12/01/2009 08:44 AM, Alexandre Hardy wrote:
> +    length = (*pGetLongPathNameW)(unc_path,NULL,0);

Why the brackets around *pGetLongPathNameW?
> +    ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length);

You called the W-function so the ok text needs to be adjusted. You also 
know the length so why not check explicitly?

-- 
Cheers,

Paul.

dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

[Paul Vriens]

On 12/01/2009 11:52 AM, Paul Vriens wrote:
> On 12/01/2009 08:44 AM, Alexandre Hardy wrote:
> > + length = (*pGetLongPathNameW)(unc_path,NULL,0);
>
> Why the brackets around *pGetLongPathNameW?
> > + ok(length>0,"GetLongPathNameA: Failed on UNC Pathname
> > (length=%d)\n",length);
>
> You called the W-function so the ok text needs to be adjusted. You also
> know the length so why not check explicitly?

Hi Alexandre,

Another thing is that your test doesn't proof that what you are changing 
is correct.

You probably need a pre-filled buffer that you check after the call to 
see if that buffer indeed wasn't touched when the buffersize was too small.

-- 
Cheers,

Paul.