Re: [PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open

[Tomas Carnecky]

Maarten Lankhorst wrote:
> Sanity check to see if device can be opened or not

Is alloca() not allowed in wine? (asking because you allocate hw_params
on the stack, but it's freed if the function exits, so it's only used
inside this one function).

tom

[PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open

[Maarten Lankhorst]

Hi Tomas,

Tomas Carnecky schreef:
> Is alloca() not allowed in wine? (asking because you allocate hw_params
> on the stack, but it's freed if the function exits, so it's only used
> inside this one function).

Last time I tried using alloca in alsa volume control it was rejected,
so I'm just walking safe path.

Cheers,
Maarten

[PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open

[Tomas Carnecky]

Maarten Lankhorst wrote:
> Last time I tried using alloca in alsa volume control it was rejected,
> so I'm just walking safe path.

Well the existing coded uses alloca() ... just saw this while compiling
wine (winealsa.drv):

waveout.c: In function 'wodOpen':
waveout.c:582: warning: the address of 'sw_params' will always evaluate
as 'true'

which I know very well, it's from snd_*_alloca() macros,
snd_pcm_sw_params_alloca() is this case.

tom