Re: [1/3] gdiplus: Implement GdipSetImageAttributesGamma.

[Paul Vriens]

On 01/31/2010 02:03 AM, Vincent Povirk wrote:
> +    stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color);
> +    expect(Ok, stat);
> +    todo_wine expect(0xff20ffff, color);

Hi Vincent,

This one introduces a test failure on what appears to be mostly VMware 
boxes. Not all VMware boxes show this failure btw and I did see the same 
failure on a real WinMe box.

Would a color_match (like we use in several other tests) be more 
appropriate or maybe a broken()?

-- 
Cheers,

Paul.

[1/3] gdiplus: Implement GdipSetImageAttributesGamma.

[Vincent Povirk]

On Tue, Feb 2, 2010 at 2:14 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> On 01/31/2010 02:03 AM, Vincent Povirk wrote:
> > +    stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color);
> > +    expect(Ok, stat);
> > +    todo_wine expect(0xff20ffff, color);
>
> Hi Vincent,
>
> This one introduces a test failure on what appears to be mostly VMware
> boxes. Not all VMware boxes show this failure btw and I did see the same
> failure on a real WinMe box.
>
> Would a color_match (like we use in several other tests) be more appropriate
> or maybe a broken()?

color_match would make sense.

I find it odd, though, that gamma adjustment would change 255 (100%
brightness) to 254 (less than 100% brightness). I may be missing
something.