Re: riched20: Set pStream->written in ME_StreamOutFlush.
On Thu, Oct 29, 2015 at 01:20:57PM +0800, Jactry Zeng wrote:
diff --git a/dlls/riched20/writer.c b/dlls/riched20/writer.c index 2c7386a..72a8db5 100644 --- a/dlls/riched20/writer.c +++ b/dlls/riched20/writer.c @@ -63,6 +63,7 @@ ME_StreamOutFlush(ME_OutStream *pStream) /* Don't resend partial chunks if nWritten < pStream->pos */ } pStream->pos = 0; + pStream->written += nWritten; return TRUE; }
While this is probably correct, it would be easy to add tests for this. We already have EM_STREAMOUT tests, so just add checks on their return values. Huw.
Hi Huw, 2015-11-03 22:37 GMT+08:00 Huw Davies <huw(a)codeweavers.com>:
While this is probably correct, it would be easy to add tests for this. We already have EM_STREAMOUT tests, so just add checks on their return values.
Thanks for your review! Yes, you are right. I also had tried to add some tests for it. But Wine's rtf header is different to Windows'. So when we test EM_STREAMOUT with SF_RTF, return value given by Wine's EM_STREAMOUT will always different to Windows'. SF_TEXT will be fine. Can I just append tests of SF_TEXT? Or skip those tests on Windows? -- Regards, Jactry Zeng
On Wed, Nov 04, 2015 at 10:46:25AM +0800, Jactry Zeng wrote:
Hi Huw, 2015-11-03 22:37 GMT+08:00 Huw Davies <huw(a)codeweavers.com>:
While this is probably correct, it would be easy to add tests for this. We already have EM_STREAMOUT tests, so just add checks on their return values.
Thanks for your review!
Yes, you are right. I also had tried to add some tests for it. But Wine's rtf header is different to Windows'. So when we test EM_STREAMOUT with SF_RTF, return value given by Wine's EM_STREAMOUT will always different to Windows'. SF_TEXT will be fine. Can I just append tests of SF_TEXT? Or skip those tests on Windows?
Just keep a count of the number of bytes sent to the callback and compare the return value to that. Huw.
participants (2)
-
Huw Davies -
Jactry Zeng