Re: MSI: First go at thread safety for MSI records

[Alexandre Julliard]

Mike McCormack <mike(a)codeweavers.com> writes:
> Index: dlls/msi/msipriv.h
> ===================================================================
> RCS file: /home/wine/wine/dlls/msi/msipriv.h,v
> retrieving revision 1.32
> diff -u -r1.32 msipriv.h
> --- dlls/msi/msipriv.h	22 Dec 2004 15:05:07 -0000	1.32
> +++ dlls/msi/msipriv.h	23 Dec 2004 01:43:40 -0000
> @@ -54,6 +54,7 @@
>      UINT magic;
>      UINT type;
>      UINT refcount;
> +    CRITICAL_SECTION cs;
>      msihandledestructor destructor;

Do you really need a separate critical section for every single MSI
object?  That seems a bit overkill to me.

-- 
Alexandre Julliard
julliard(a)winehq.org

MSI: First go at thread safety for MSI records

[Mike McCormack]

Alexandre Julliard wrote:
> Do you really need a separate critical section for every single MSI
> object?  That seems a bit overkill to me.

What do you suggest?

Mike

MSI: First go at thread safety for MSI records

[Robert Shearman]

Mike McCormack wrote:
> Alexandre Julliard wrote:
> > Do you really need a separate critical section for every single MSI
> > object?  That seems a bit overkill to me.
>
> What do you suggest?

Keep the msiobj_lock/msiobj_unlock functions, but make them use a 
process-wide critical section. It will then be simple to add a per 
object critical section if it is proved that performance is suffering.

Rob

MSI: First go at thread safety for MSI records

[Mike Hearn]

On Thu, 23 Dec 2004 21:11:41 +0000, Mike McCormack wrote:
> What do you suggest?

Prove you're a real man by doing everything including linked lists
using the Interlocked functions and busy-wait loops.

Critical sections are for wimps ;)