Re: [v2] gdi32: return non-zero v-refresh value for display devices.

19 Jul 2017

On Wed, Jul 19, 2017 at 11:28:58PM +0900, Akihiro Sagawa wrote:
...

diff --git a/dlls/gdi32/tests/dc.c b/dlls/gdi32/tests/dc.c
index add2c04..2b48542 100644
--- a/dlls/gdi32/tests/dc.c
+++ b/dlls/gdi32/tests/dc.c
@@ -445,6 +445,7 @@ static void test_device_caps( HDC hdc, HDC ref_dc, const char *descr, int scale
     if (type != COMPLEXREGION && type != ERROR)  /* region can be complex on multi-monitor setups */
     {
         RECT ref_rect;
+        int rate = GetDeviceCaps( ref_dc, VREFRESH );
ok( type == SIMPLEREGION, "GetClipBox returned %d on %s\n", type, descr );
         if (GetDeviceCaps( ref_dc, TECHNOLOGY ) == DT_RASDISPLAY)
@@ -462,11 +463,15 @@ static void test_device_caps( HDC hdc, HDC ref_dc, const char *descr, int scale
             SetRect( &ref_rect, GetSystemMetrics( SM_XVIRTUALSCREEN ), GetSystemMetrics( SM_YVIRTUALSCREEN ),
                      GetSystemMetrics( SM_XVIRTUALSCREEN ) + GetSystemMetrics( SM_CXVIRTUALSCREEN ),
                      GetSystemMetrics( SM_YVIRTUALSCREEN ) + GetSystemMetrics( SM_CYVIRTUALSCREEN ) );
+
+            ok( rate >= 1 && rate <= 85, "returned rate is out of range (1 -- 85), got %d\n", rate);
Don't check the range, just that it's != 0.

Also, please move this to a new VREFRESH case in the switch block
higher up in this function.

Huw.

    

Huw Davies