[PATCH] shell32: Fix an item identifier list leak (Valgrind).
Signed-off-by: Sven Baars <sven.wine(a)gmail.com> --- dlls/shell32/brsfolder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c index 37363a1cec..d71ec62099 100644 --- a/dlls/shell32/brsfolder.c +++ b/dlls/shell32/brsfolder.c @@ -783,6 +783,8 @@ static BOOL BrsFolder_OnCreate( HWND hWnd, browse_info *info ) browsefolder_callback( info->lpBrowseInfo, hWnd, BFFM_INITIALIZED, 0 ); + ILFree(computer_pidl); + return TRUE; } -- 2.17.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=53155 Your paranoid android. === debian9 (32 bit WoW report) === shell32: shelllink.c:811: Test failed: save failed (0x80070020) shelllink.c:811: Test failed: got 0x00000001 shelllink.c:811: Test failed: Didn't expect NULL shelllink.c:506: Test failed: GetCurFile fails on shell32 < 5.0 shelllink.c:813: Test failed: GetIconLocation returned 'C:\users\winetest\Temp\test.txt' instead of 'C:\users\winetest\Temp\\test.txt'
participants (2)
-
Marvin -
Sven Baars