[PATCH] shlwapi/tests: Document where SHFormatDateTimeA() crashes for NULL pointers.

[Francois Gouget]

Knowing which Windows versions have been confirmed to crash will make it
easier to know whether that information is potentially obsolete if the
Windows behavior changes.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---
I chose to put the comment on the same line as the if (0) so it is
visible even with a simple source grep.
---
 dlls/shlwapi/tests/ordinal.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c
index bf43d35b1c2..15011bbdde4 100644
--- a/dlls/shlwapi/tests/ordinal.c
+++ b/dlls/shlwapi/tests/ordinal.c
@@ -1674,11 +1674,8 @@ static void test_SHFormatDateTimeA(void)
     DWORD flags;
     INT ret;
 
-if (0)
-{
-    /* crashes on native */
+    if (0) /* crashes on Windows XP to Windows 10 20H2 */
     pSHFormatDateTimeA(NULL, NULL, NULL, 0);
-}
 
     GetLocalTime(&st);
     SystemTimeToFileTime(&st, &filetime);
-- 
2.30.2

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=96885

Your paranoid android.


=== debiant2 (32 bit Hindi:India report) ===

shlwapi:
ordinal.c:1724: Test failed: expected ( ), got (08:02)
ordinal.c:1731: Test failed: expected ( ), got (08:02:55)
ordinal.c:1739: Test failed: expected ( ), got (08:02:55)
ordinal.c:1746: Test failed: expected ( ), got (31-08-2021)
ordinal.c:1753: Test failed: expected ( ), got (31 ????? 2021)
ordinal.c:1761: Test failed: expected ( ), got (31 ????? 2021)
ordinal.c:1769: Test failed: expected (F), got (2) for time part
ordinal.c:1783: Test failed: expected (F), got (5) for time part
ordinal.c:1801: Test failed: expected (  F), got (31-08-2021 08:02)
ordinal.c:1812: Test failed: expected (  F F), got (31-08-2021 08:02:55)

[Francois Gouget]

On Tue, 31 Aug 2021, Marvin wrote:
[...]
> === debiant2 (32 bit Hindi:India report) ===
>
> shlwapi:
> ordinal.c:1724: Test failed: expected ( ), got (08:02)
> ordinal.c:1731: Test failed: expected ( ), got (08:02:55)
> ordinal.c:1739: Test failed: expected ( ), got (08:02:55)
> ordinal.c:1746: Test failed: expected ( ), got (31-08-2021)
> ordinal.c:1753: Test failed: expected ( ), got (31 ????? 2021)
> ordinal.c:1761: Test failed: expected ( ), got (31 ????? 2021)
> ordinal.c:1769: Test failed: expected (F), got (2) for time part
> ordinal.c:1783: Test failed: expected (F), got (5) for time part
> ordinal.c:1801: Test failed: expected (  F), got (31-08-2021 08:02)
> ordinal.c:1812: Test failed: expected (  F F), got (31-08-2021 08:02:55)

This is the Hindi locale issue (will also appear on the other shlwapi 
patch):
https://bugs.winehq.org//show_bug.cgi?id=51407

-- 
Francois Gouget <fgouget(a)codeweavers.com>

[Zebediah Figura (she/her)]

On 8/31/21 7:53 AM, Francois Gouget wrote:
> Knowing which Windows versions have been confirmed to crash will make it
> easier to know whether that information is potentially obsolete if the
> Windows behavior changes.
>
> Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
> ---
> I chose to put the comment on the same line as the if (0) so it is
> visible even with a simple source grep.
> ---
>   dlls/shlwapi/tests/ordinal.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c
> index bf43d35b1c2..15011bbdde4 100644
> --- a/dlls/shlwapi/tests/ordinal.c
> +++ b/dlls/shlwapi/tests/ordinal.c
> @@ -1674,11 +1674,8 @@ static void test_SHFormatDateTimeA(void)
>       DWORD flags;
>       INT ret;
>
> -if (0)
> -{
> -    /* crashes on native */
> +    if (0) /* crashes on Windows XP to Windows 10 20H2 */
>       pSHFormatDateTimeA(NULL, NULL, NULL, 0);
> -}
>
> GetLocalTime(&st);
>       SystemTimeToFileTime(&st, &filetime);

I don't personally care where the if (0) is, but if it's going to be 
there, could we maybe indent the body?