Re: [PATCH 2/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida.
Qian Hong <fracting(a)gmail.com> writes:
+static inline void set_cache_invalid_char(const HDC hdc, ScriptCache *sc) +{ +#define Zero_width_space 0x200b /* Zero Width Space */ +#define Invalid_char3 0xf71b /* Unknow, found by black box testing */ +#define NON_EXIST_INDEX 0xffff /* Default non exist char index */ + WCHAR invalid_chars[3] = {Numeric_space, Zero_width_space, Invalid_char3};
There's no reason to add #defines for that kind of thing, just put the values in the string directly. -- Alexandre Julliard julliard(a)winehq.org
Hello, On Wed, Nov 14, 2012 at 2:22 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
There's no reason to add #defines for that kind of thing, just put the values in the string directly.
Thanks for comment, will remove these #defines. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/
participants (2)
-
Alexandre Julliard -
Qian Hong