Re: [PATCH 1/5] winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX().

[Chris Robinson]

On Tuesday, March 27, 2012 8:35:49 PM Henri Verbeet wrote:
> -  int pixelattrib = ~0;
> +  int pixelattrib = GLX_DONT_CARE;

I want to say there's a reason we used ~0 instead of GLX_DONT_CARE, but it's 
been too long that I can't remember. I think it was because GLX_DONT_CARE 
didn't include all possibilities that ~0 would, like what WGL wanted.

[PATCH 1/5] winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX().

[Henri Verbeet]

On 28 March 2012 07:24, Chris Robinson <chris.kcat(a)gmail.com> wrote:
> On Tuesday, March 27, 2012 8:35:49 PM Henri Verbeet wrote:
> > -  int pixelattrib = ~0;
> > +  int pixelattrib = GLX_DONT_CARE;
>
> I want to say there's a reason we used ~0 instead of GLX_DONT_CARE, but it's
> been too long that I can't remember. I think it was because GLX_DONT_CARE
> didn't include all possibilities that ~0 would, like what WGL wanted.

Well, GLX_DONT_CARE is ~0, and GLX_DONT_CARE is how the driver is
going to interpret this, the patch just gets rid of a magic constant.
(For the background on this, this patch was prompted by
http://lists.freedesktop.org/archives/piglit/2012-March/002132.html to
the piglit mailing list, which is related to fd.o 47478 and winehq
26763.)