Re: ole32: Add Co*InitializeSpy functions

[Rob Shearman]

2008/11/26 Maarten Lankhorst <maarten(a)codeweavers.com>:
> +
> +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie)
> +{
> +    struct oletls *info = COM_CurrentInfo();
> +    TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart));
> +
> +    if (!info || !info->spy || cookie.QuadPart != (DWORD_PTR)info->spy)
> +        return E_INVALIDARG;
> +
> +    IUnknown_Release(info->spy);
> +    return S_OK;
> +}

No function documentation and you forget to clear info->spy before returning.

-- 
Rob Shearman

ole32: Add Co*InitializeSpy functions

[Maarten Lankhorst]

Hi Rob,

Rob Shearman schreef:
> 2008/11/26 Maarten Lankhorst <maarten(a)codeweavers.com>:
> > +
> > +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie)
> > +{
> > +    struct oletls *info = COM_CurrentInfo();
> > +    TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart));
> > +
> > +    if (!info || !info->spy || cookie.QuadPart != (DWORD_PTR)info->spy)
> > +        return E_INVALIDARG;
> > +
> > +    IUnknown_Release(info->spy);
> > +    return S_OK;
> > +}
>
> No function documentation and you forget to clear info->spy before returning.

I sent a patch that fixes that, and also releases it on TlsDestroy.

Cheers,
Maarten.