Re: [2/2] netapi32: Added partial implementation of NetShareGetInfo

[Juan Lang]

Hi again Vitaliy,

+/************************************************************/
+WCHAR *ParseParam(WCHAR **paramStr, const WCHAR *name)

This should be static.  The name of the function also shouldn't be
capitalized like this, to make it clear that it isn't a Win32
function.  Looking at other source files in netapi32, either
NETAPI_ParseParam or simply parse_param would be better.  Also, some
comments for it would be nice.  In particular, the meaning of paramStr
and the return value aren't clear from the function name.

+    FIXME("(%s %s %d %p) partially implemented\n", debugstr_w(servername),
+        debugstr_w(netname), level, bufptr);
As with patch 1, a TRACE is probably better here.

+    size = 512;
+    result = RegQueryValueExW(hKey, netname, NULL, NULL, (LPBYTE)
paramStr, &size);
This isn't actually a correct value for size, size = sizeof(paramStr)
would be correct (and less prone to future error.)  Can the value
become bigger than 512 characters?

--Juan