[PATCH v3] riched20: implement ITextRange/ITextSelection Copy and Cut

[Damjan Jovanovic]

Try 3 fixes copying from a password masked richedit control,
and gets tests to pass.

Clipboard handling is unified with the previous code in editor.c.
Manual tests show trying to cut from a read-only field beeps when
using WM_CUT or Ctrl+X, but not when using these APIs.

Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com>
---
 dlls/riched20/caret.c         |  2 +-
 dlls/riched20/editor.c        | 53 ++++++++++++++++---------
 dlls/riched20/editor.h        |  3 +-
 dlls/riched20/richole.c       | 46 ++++++++++++++++++----
 dlls/riched20/tests/richole.c | 74 +++++++++++++++++++++++++++++++++++
 5 files changed, 149 insertions(+), 29 deletions(-)

[Huw Davies]

On Thu, Oct 15, 2020 at 06:21:43AM +0200, Damjan Jovanovic wrote:
> Try 3 fixes copying from a password masked richedit control,
> and gets tests to pass.
>
> Clipboard handling is unified with the previous code in editor.c.
> Manual tests show trying to cut from a read-only field beeps when
> using WM_CUT or Ctrl+X, but not when using these APIs.

Hi Damjan,

Thanks for the patch.  There were a few issues,
most notably with the handling of the IDataObject
out interface.  Rather than have you fix them
and run into changes that I'm making at the moment,
I've fixed it up myself and sent it in.

Huw.

[Damjan Jovanovic]

On Thu, Oct 15, 2020 at 11:29 AM Huw Davies <huw(a)codeweavers.com> wrote:
> On Thu, Oct 15, 2020 at 06:21:43AM +0200, Damjan Jovanovic wrote:
> > Try 3 fixes copying from a password masked richedit control,
> > and gets tests to pass.
> >
> > Clipboard handling is unified with the previous code in editor.c.
> > Manual tests show trying to cut from a read-only field beeps when
> > using WM_CUT or Ctrl+X, but not when using these APIs.
>
> Hi Damjan,
>
> Thanks for the patch.  There were a few issues,
> most notably with the handling of the IDataObject
> out interface.  Rather than have you fix them
> and run into changes that I'm making at the moment,
> I've fixed it up myself and sent it in.
>
> Huw.

Great, thank you :).

And thank you for your other contributions to riched20, that DLL still
breaks quite a few apps.

Damjan