[PATCH v2 3/4] windowscodecs/tests: Add more tests for DdsFrameDecode_Dds_CopyBlocks() when "boundsInBlocks" is NULL.

[Ziqing Hui]

The added tests shows that when boundsInBlocks parameter is NULL, stride parameter will be checked to ensure it is bigger or equal to frame stride, but it will be ignored in the call. This can be proved by:

* CopyBlocks(NULL, frame_stride - 1, sizeof(buffer), buffer) return error.
* CopyBlocks(NULL, frame_stride, sizeof(buffer), buffer) and CopyBlocks(NULL, frame_stride * 2, sizeof(buffer), buffer) works fine and result in same buffer content.

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com>
---
 dlls/windowscodecs/tests/ddsformat.c | 37 ++++++++++++++++++++++------
 1 file changed, 30 insertions(+), 7 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=73100

Your paranoid android.


=== debiant (32 bit report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41208 bytes)

=== debiant (32 bit French report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41210 bytes)

=== debiant (32 bit Japanese:Japan report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41210 bytes)

=== debiant (32 bit Chinese:China report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41208 bytes)

=== debiant (32 bit WoW report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41208 bytes)

=== debiant (64 bit WoW report) ===

Report validation errors:
windowscodecs:ddsformat prints too much data (41208 bytes)

[Ziqing Hui]

The testbot prints too much data, but there's no test failures. There are tests for each frame of the image, so it prints too much log. So this is not a test failure.

On 6/9/20 1:21 PM, Marvin wrote:
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=73100
>
> Your paranoid android.
>
> === debiant (32 bit report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41208 bytes)
>
> === debiant (32 bit French report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41210 bytes)
>
> === debiant (32 bit Japanese:Japan report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41210 bytes)
>
> === debiant (32 bit Chinese:China report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41208 bytes)
>
> === debiant (32 bit WoW report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41208 bytes)
>
> === debiant (64 bit WoW report) ===
>
> Report validation errors:
> windowscodecs:ddsformat prints too much data (41208 bytes)

[Zhiyi Zhang]

On 6/9/20 7:05 PM, Ziqing Hui wrote:
> The testbot prints too much data, but there's no test failures. There are tests for each frame of the image, so it prints too much log. So this is not a test failure.
> You should make the test log less verbose. Should this get accepted, TestBots wouldn't be able to catch new failures.
> On 6/9/20 1:21 PM, Marvin wrote:
> > Hi,
> >
> > While running your changed tests, I think I found new failures.
> > Being a bot and all I'm not very good at pattern recognition, so I might be
> > wrong, but could you please double-check?
> >
> > Full results can be found at:
> > https://testbot.winehq.org/JobDetails.pl?Key=73100
> >
> > Your paranoid android.
> >
> > === debiant (32 bit report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41208 bytes)
> >
> > === debiant (32 bit French report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41210 bytes)
> >
> > === debiant (32 bit Japanese:Japan report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41210 bytes)
> >
> > === debiant (32 bit Chinese:China report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41208 bytes)
> >
> > === debiant (32 bit WoW report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41208 bytes)
> >
> > === debiant (64 bit WoW report) ===
> >
> > Report validation errors:
> > windowscodecs:ddsformat prints too much data (41208 bytes)

[Esme Povirk (they/them)]

Signed-off-by: Esme Povirk <vincent(a)codeweavers.com>

I guess this patch represents an intermediate state where the test
data is too large for testbot. I'll let someone else decide if that's
acceptable.