Re: WS2_32: WSACleanup implementation, server-side, plus remove todos around passing tests. This also fixes bug 32910
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16405 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found
How do I read this test failure? I don’t see any real clues. -Matt
On Aug 29, 2015, at 4:32 PM, Marvin <testbot(a)winehq.org> wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16405
Your paranoid android.
=== w2008s64 (64 bit sock) === No test summary line found
On Saturday, August 29, 2015, Matt Durgavich <mattdurgavich(a)gmail.com <javascript:_e(%7B%7D,'cvml','mattdurgavich(a)gmail.com');>> wrote:
How do I read this test failure? I don’t see any real clues.
That is not your fault, just ignore that error. Your subject is overly long too and I didn't catch it earlier but you are using 2 space indentation in Wsacleanup while the rest of the function uses 4 spaces, so please change that. A better subject would be : ws2_32: Implement WSACleanup The details about what bugs are fixed should go in the email body.
participants (3)
-
Bruno Jesus -
Marvin -
Matt Durgavich