Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests
On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
Fix last error in SearchPathA/W with tests
Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? SearchPathA is implemented on Win98. SearchPathW is exported but not implemented. This means the current tests will fail on Win98 for example: path.c:1490: Test failed: Expected ERROR_INVALID_PARAMETER, got 2 path.c:1497: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 path.c:1504: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 So SearchPathA returns something different for the last error and the SearchPathW tests already fail because GetWindowsDirectoryW() is not implemented (next to SearchPathW itself not being implemented of course). -- Cheers, Paul.
On 12/21/2009 17:21, Paul Vriens wrote:
On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
Fix last error in SearchPathA/W with tests
Hi Nikolay,
Any reason all tests are relying on both the A- and W-version being available?
MSDN lied again, it's documented to be available in win2k.
SearchPathA is implemented on Win98. SearchPathW is exported but not implemented. This means the current tests will fail on Win98 for example:
path.c:1490: Test failed: Expected ERROR_INVALID_PARAMETER, got 2 path.c:1497: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 path.c:1504: Test failed: Expected ERROR_INVALID_PARAMETER, got 78
So SearchPathA returns something different for the last error and the SearchPathW tests already fail because GetWindowsDirectoryW() is not implemented (next to SearchPathW itself not being implemented of course).
I see, probably it's better to determine win9x indirectly here, to avoid not obvious checks, I'll take a look for tomorrow patch set, playing with testbot.
On 12/21/2009 03:37 PM, Nikolay Sivov wrote:
On 12/21/2009 17:21, Paul Vriens wrote:
On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
Fix last error in SearchPathA/W with tests
Hi Nikolay,
Any reason all tests are relying on both the A- and W-version being available?
MSDN lied again, it's documented to be available in win2k.
Well, I've noticed that most of the pages contain win2k as the minimum probably because they don't support NT4/Win9x anymore?
I see, probably it's better to determine win9x indirectly here, to avoid not obvious checks, I'll take a look for tomorrow patch set, playing with testbot.
A check for last error being ERROR_CALL_NOT_IMPLEMENTED after GetWindowsDirectoryW would suffice I guess. -- Cheers, Paul.
On 12/21/2009 17:49, Paul Vriens wrote:
On 12/21/2009 03:37 PM, Nikolay Sivov wrote:
On 12/21/2009 17:21, Paul Vriens wrote:
On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
Fix last error in SearchPathA/W with tests
Hi Nikolay,
Any reason all tests are relying on both the A- and W-version being available?
MSDN lied again, it's documented to be available in win2k.
Well, I've noticed that most of the pages contain win2k as the minimum probably because they don't support NT4/Win9x anymore? Maybe, but sometimes earlier version mentioned too. Doesn't matter actually.
I see, probably it's better to determine win9x indirectly here, to avoid not obvious checks, I'll take a look for tomorrow patch set, playing with testbot.
A check for last error being ERROR_CALL_NOT_IMPLEMENTED after GetWindowsDirectoryW would suffice I guess.
Maybe, if you have some time for it please do it, I can't be ready for today commits. The only things matters here is to keep all tests from this patch, cause Wine's implementation differs for W/A in parameter checks.
participants (2)
-
Nikolay Sivov -
Paul Vriens