Re: [9/10] WineD3D: Update the overlay when the destination was drawn to

[Alexandre Julliard]

Stefan Dösinger <stefan(a)codeweavers.com> writes:
> @@ -4550,13 +4558,22 @@ static WINED3DSURFTYPE WINAPI IWineD3DSurfaceImpl_GetImplType(IWineD3DSurface *i
>  static HRESULT WINAPI IWineD3DSurfaceImpl_DrawOverlay(IWineD3DSurface *iface) {
>      IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *) iface;
>      HRESULT hr;
> +    static BOOL recursive = FALSE;

That static looks very suspicious. It should either be stored in the
object or use some sort of locking.

-- 
Alexandre Julliard
julliard(a)winehq.org

[9/10] WineD3D: Update the overlay when the destination was drawn to

[Stefan Dösinger]

> > +    static BOOL recursive = FALSE;
>
> That static looks very suspicious. It should either be stored in the
> object or use some sort of locking.
> Well, there is locking, it is done by the client library(ddraw, d3d8, d3d9). Still storing this in the object is a good idea I think