Re: Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.

[Michael Stefaniuc]

Juan,

On 12/04/2009 04:11 PM, Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 82d07c405168df59db17d298bc3b8476f13540e9
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=82d07c405168df59db17d298bc...
>
> Author: Juan Lang<juan.lang(a)gmail.com>
> Date:   Thu Dec  3 11:28:40 2009 -0800
>
> winhttp: Check the certificate in an https connection using the crypto api.
> this breaks compilation on Fedora 12; F11 works fine though.

gcc -c -I/home/michi/work/wine/dlls/winhttp -I. 
-I/home/michi/work/wine/include -I../../include  -D__WINESRC__ 
-D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing 
-Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings 
-Wtype-limits -Wpointer-arith  -g -O2  -o net.o 
/home/michi/work/wine/dlls/winhttp/net.c
/home/michi/work/wine/dlls/winhttp/net.c: In function 
‘netconn_secure_verify’:
/home/michi/work/wine/dlls/winhttp/net.c:342: error: ‘struct 
stack_st_X509’ has no member named ‘num’
/home/michi/work/wine/dlls/winhttp/net.c:346: error: ‘struct 
stack_st_X509’ has no member named ‘data’
/home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_init’:
/home/michi/work/wine/dlls/winhttp/net.c:450: warning: assignment 
discards qualifiers from pointer target type
make: *** [net.o] Error 1

bye
	michael

Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.

[Juan Lang]

Hi Michael,
> this breaks compilation on Fedora 12; F11 works fine though.

Does the attached patch help?
--Juan

Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.

[Michael Stefaniuc]

Hello Juan!

On 12/05/2009 12:15 AM, Juan Lang wrote:
> > this breaks compilation on Fedora 12; F11 works fine though.
>
> Does the attached patch help?
> Yes, it compiles now but has warnings:
> dlls/winhttp/net.c: In function ‘netconn_secure_verify’:
> dlls/winhttp/net.c:344: warning: passing argument 1 of ‘psk_num’ from 
> incompatible pointer type
> dlls/winhttp/net.c:344: note: expected ‘const struct _STACK *’ but 
> argument is of type ‘struct stack_st_X509 *’
> dlls/winhttp/net.c:348: warning: passing argument 1 of ‘psk_value’ from 
> incompatible pointer type
> dlls/winhttp/net.c:348: note: expected ‘const struct _STACK *’ but 
> argument is of type ‘struct stack_st_X509 *’
> dlls/winhttp/net.c: In function ‘netconn_init’:
> dlls/winhttp/net.c:454: warning: assignment discards qualifiers from 
> pointer target type

F11 still compiles error and warning free.

thanks
bye
	michael