Re: [1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=17422

Your paranoid android.


=== build (build) ===
Make failed

[1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)

[Bruno Jesus]

On Sat, Oct 17, 2015 at 8:55 PM, Marvin <testbot(a)winehq.org> wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=17422
>
> Your paranoid android.
>
> === build (build) ===
> Make failed

No idea why it could happen. I'm open to hints.

[1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)

[Nikolay Sivov]

On 17.10.2015 16:18, Bruno Jesus wrote:
> On Sat, Oct 17, 2015 at 8:55 PM, Marvin <testbot(a)winehq.org> wrote:
> > Hi,
> >
> > While running your changed tests on Windows, I think I found new failures.
> > Being a bot and all I'm not very good at pattern recognition, so I might be
> > wrong, but could you please double-check?
> > Full results can be found at
> > https://testbot.winehq.org/JobDetails.pl?Key=17422
> >
> > Your paranoid android.
> >
> > === build (build) ===
> > Make failed
>
> No idea why it could happen. I'm open to hints.

Maybe you need to add avifil32 to IMPORTS for test exe?

[1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)

[Bruno Jesus]

On Sat, Oct 17, 2015 at 9:22 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> > > === build (build) ===
> > > Make failed
> >
> > No idea why it could happen. I'm open to hints.
>
> Maybe you need to add avifil32 to IMPORTS for test exe?

Thanks, I think you may both be right. Indeed I forgot to add the
Makefile change in the commit and the AVI file is 20kb (copied from
shell32/searching.avi). 20kb of char array is too ugly so I'm open for
ideas. I may also try making my own 1x1 uncompressed video but I thing
1x1 is not allowed =)

Thanks,
Bruno

[1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)

[Sebastian Lackner]

On 17.10.2015 15:18, Bruno Jesus wrote:
> On Sat, Oct 17, 2015 at 8:55 PM, Marvin <testbot(a)winehq.org> wrote:
> > Hi,
> >
> > While running your changed tests on Windows, I think I found new failures.
> > Being a bot and all I'm not very good at pattern recognition, so I might be
> > wrong, but could you please double-check?
> > Full results can be found at
> > https://testbot.winehq.org/JobDetails.pl?Key=17422
> >
> > Your paranoid android.
> >
> > === build (build) ===
> > Make failed
>
> No idea why it could happen. I'm open to hints.

Not sure about the testbot issue, but you cannot expect that files in the source tree
are also available while running the tests. You either have to add it as a char[] array
(if not too big and ugly) or as resource section, and then extract it at runtime.