Anything wrong with my patch from 16.10. about w32x86 and win40 creation?
I think it's not a big deal but would help making on of our EmTec products more compatible... Markus
Ups, I checked it here again and I can see an attachment which looks ok... It's not so easy to use Windows tools on a Linux newsgroup :-/ Can someone else please check what I'm doing wrong here? Thanks Markus
Am Dienstag, 23. Oktober 2007 11:53:52 schrieb Markus Gömmel:
Ups, I checked it here again and I can see an attachment which looks ok...
It's not so easy to use Windows tools on a Linux newsgroup :-/ It is a mailing list actually, not a newsgroup. There are some mailing list<->newsgroup bridges though.
X-Newsreader: Microsoft Windows Mail 6.0.6000.16480 X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6000.16545 I don't know what sort of enchanted features Windows Mail uses, but make sure that the patch is attached as a normal text file without any fancy OLE fun and so on:
This is how your mail arrived at the mailing list archive as far as I can see: http://www.winehq.org/pipermail/wine-patches/2007-October/045287.html A file is attached, but it is empty.
Can you see if my 3rd try is valid now? Should be come through in the next minutes... Thanks for all your help Markus
Am Dienstag, 23. Oktober 2007 15:07:16 schrieb Markus Gömmel:
Can you see if my 3rd try is valid now? Should be come through in the next minutes...
Thanks for all your help Looks good from the sending side. I can't comment on the printing stuff though
On Tue, Oct 23, 2007 at 02:53:19PM +0200, Stefan Dösinger wrote:
This is how your mail arrived at the mailing list archive as far as I can see: http://www.winehq.org/pipermail/wine-patches/2007-October/045287.html
It seems that is a problem with pipermail. It displays fine with mutt (from local archives) and also gmane: http://article.gmane.org/gmane.comp.emulators.wine.patches/42763/ I suppose it was rejected by AJ based on the patch content. The 3rd try is worse as its attachment has a mime-type of application/octet-stream instead of text/plain: http://article.gmane.org/gmane.comp.emulators.wine.patches/43071/ Our pipermail also has it as 0 bytes long: http://www.winehq.org/pipermail/wine-patches/2007-October/045650.html Btw. a very nice feature of gmane is to get archived mail in a raw form (although it ran through gmanes mail to news filter, but that shouldn't remove any information) by adding /raw to the url: http://article.gmane.org/gmane.comp.emulators.wine.patches/42763/raw Jan
On Wed, Oct 24, 2007 at 01:29:03PM +0200, Jan Zerebecki wrote:
On Tue, Oct 23, 2007 at 02:53:19PM +0200, Stefan Dösinger wrote:
This is how your mail arrived at the mailing list archive as far as I can see: http://www.winehq.org/pipermail/wine-patches/2007-October/045287.html
It seems that is a problem with pipermail. It displays fine with mutt (from local archives) and also gmane: http://article.gmane.org/gmane.comp.emulators.wine.patches/42763/
I suppose it was rejected by AJ based on the patch content.
The 3rd try is worse as its attachment has a mime-type of application/octet-stream instead of text/plain: http://article.gmane.org/gmane.comp.emulators.wine.patches/43071/
Sorry I missed that the 2nd try had "Content-Transfer-Encoding: quoted-printable" which works fine with mutt and gmane but some tools probably don't support it (I guess the git tools may have problems with emails that have their patch attached in that format). The best way to test if your mail is in the correct format is by trying to apply it with git (the whole mail as mbox, not only the attachment). Jan
On Wed, Oct 24, 2007 at 01:29:03PM +0200, Jan Zerebecki wrote:
On Tue, Oct 23, 2007 at 02:53:19PM +0200, Stefan Dösinger wrote:
This is how your mail arrived at the mailing list archive as far as I can see: http://www.winehq.org/pipermail/wine-patches/2007-October/045287.html
It seems that is a problem with pipermail. It displays fine with mutt (from local archives) and also gmane: http://article.gmane.org/gmane.comp.emulators.wine.patches/42763/
I suppose it was rejected by AJ based on the patch content.
The 3rd try is worse as its attachment has a mime-type of application/octet-stream instead of text/plain: http://article.gmane.org/gmane.comp.emulators.wine.patches/43071/
Sorry I missed that the 2nd try had "Content-Transfer-Encoding: quoted-printable" which works fine with mutt and gmane but some tools probably don't support it (I guess the git tools may have problems with emails that have their patch attached in that format). The best way to test if your mail is in the correct format is by trying to apply it with git (the whole mail as mbox, not only the attachment). Jan
Markus Gömmel <m.goemmel(a)compulab.de> writes:
I suppose it was rejected by AJ based on the patch content.
Hm, but the content of the patch is what Windows do, so rejecting cause of the content sounds a bit unlikely to me...
We of course have to create the directory, but I think it would be better if the dll that uses it did that. -- Alexandre Julliard julliard(a)winehq.org
We of course have to create the directory, but I think it would be better if the dll that uses it did that.
Hm, so you suggest putting it into WINSPOOL_LoadSystemPrinters()? Cause this looks like the only function who is definitely called during wine startup, isn't it? So we should include creation of "spool" and "spool/drivers" into this as well? Thanks for everybodies time Markus
Markus Gömmel <m.goemmel(a)compulab.de> writes:
Hm, so you suggest putting it into WINSPOOL_LoadSystemPrinters()? Cause this looks like the only function who is definitely called during wine startup, isn't it?
You could do it in GetPrinterDriverDirectory.
So we should include creation of "spool" and "spool/drivers" into this as well?
Probably, yes. -- Alexandre Julliard julliard(a)winehq.org
You could do it in GetPrinterDriverDirectory.
??? And if a Windows application simply queries systemdir and adds spool\drivers\w32x86 to copy printer driver files into it (ok, bad design, but I've seen a lot of that stuff in the past), it will still fail... And a native Windows system also comes with these both directories by default... So I think my patch is closer to the real... Anyway thanks for your time Markus
participants (5)
-
Alexandre Julliard -
Jan Z. -
Jan Zerebecki -
Markus Gömmel -
Stefan Dösinger