kernelbase: adding support for callback in CopyFileEx, and implementing CopyFile2

context: https://bugs.winehq.org/show_bug.cgi?id=55897

While implementing CopyFile2, I noticed that CopyFileEx does not respect the progress callback and never calls it. The tests too assume that it will not be invoked other than in the case of a file having multiple streams, which is not something that Wine supports.

There seem to have been multiple efforts to implement this functionality (in 2022 and 2013) but I can't tell find any reasoning for why they were not successful. Would implementing this be a desirable contribution?

I don't know how to get assigned to an issue on Bugzilla. I read the Wine Developers Wiki but it doesn't seem to have the information, so I left a comment in the bug log itself.

[Nikolay Sivov]

On Fri, Dec 1, 2023 at 6:49 PM <sendtokartavya(a)gmail.com> wrote:
> context: https://bugs.winehq.org/show_bug.cgi?id=55897
>
> While implementing CopyFile2, I noticed that CopyFileEx does not respect
> the progress callback and never calls it. The tests too assume that it will
> not be invoked other than in the case of a file having multiple streams,
> which is not something that Wine supports.

I think it's simply not implemented, there is no other reason.
> There seem to have been multiple efforts to implement this functionality
> (in 2022 and 2013) but I can't tell find any reasoning for why they were
> not successful. Would implementing this be a desirable contribution?

Sure, I recall we had a bug report for missing callbacks.
> I don't know how to get assigned to an issue on Bugzilla. I read the Wine
> Developers Wiki but it doesn't seem to have the information, so I left a
> comment in the bug log itself.

Just mention that on a bug report, there is an "Assigned to" field in
bugzilla that you can set (not sure if regular permissions allow that). But
most of the time it's not used, just create a MR, and mention it at the bug
report comment, so that it is clear you're working on it.

[Zeb Figura]

On Friday, 1 December 2023 12:22:28 CST Nikolay Sivov wrote:
> > There seem to have been multiple efforts to implement this functionality
> > (in 2022 and 2013) but I can't tell find any reasoning for why they were
> > not successful. Would implementing this be a desirable contribution?
>
> Sure, I recall we had a bug report for missing callbacks.

That'd be bug 22690 and bug 22692.

[Kartavya Vashishtha]

Adding CopyFile2 now has a MR, but I'm unsure of who I should request a
review from or how to trigger the auto-assign reviewer functionality.

https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

Sincerely,
Kartavya Vashishtha


On Fri, 1 Dec 2023 at 14:46, Zeb Figura <zfigura(a)codeweavers.com> wrote:
> On Friday, 1 December 2023 12:22:28 CST Nikolay Sivov wrote:
> > > There seem to have been multiple efforts to implement this
> > > functionality
> > > (in 2022 and 2013) but I can't tell find any reasoning for why they
> > > were
> > > not successful. Would implementing this be a desirable contribution?
> >
> > Sure, I recall we had a bug report for missing callbacks.
>
> That'd be bug 22690 and bug 22692.