Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=2280

Your paranoid android.


=== WINEBUILD (build) ===
Make failed

[PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

[David Hedberg]

On Mon, May 24, 2010 at 2:40 PM, Marvin <testbot(a)testbot.winehq.org> wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://testbot.winehq.org/JobDetails.pl?Key=2280
>
> Your paranoid android.
>
> === WINEBUILD (build) ===
> Make failed

I applied the patch generated by the testbot on top of master, and
both an ordinary build and a crosstest build seems to complete fine
for me. Am I missing something, or is the problem located elsewhere?

[PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

[Greg Geldorp]

Hi David,
> From: David Hedberg [mailto:david.hedberg(a)gmail.com]
>
> I applied the patch generated by the testbot on top of master, and
> both an ordinary build and a crosstest build seems to complete fine
> for me. Am I missing something, or is the problem located elsewhere?

It's possible that the bot didn't recompile enough of the tree. From the
build output, it's missing definitions (not declarations) of
IID_IExplorerBrowser, CLSID_ExplorerBrowser, IID_ICommDlgBrowser2 and
IID_ICommDlgBrowser3. Where are these defined? Normally I'd expect them to
end up in libuuid.a, but that doesn't seem to be linked in?
Anyway, if you successfully built a crosstest I'd submit that to the bot to
verify the tests.

Ge.