Re: Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."

[Jacek Caban]

Hi Vitaliy,

Vitaliy Margolen wrote:
> This reverts commit c32cca8066807d09e3b953aee9242eba8cfa8cdb.
>
> This patch is obviously wrong since it broke Steam Community page.

This patch is obviously good and fixed a real problem, so the problem 
must be somewhere else. I would try to fix it, but Community tab works 
fine for me so I can't test it.


Jacek

Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."

[Vitaliy Margolen]

Jacek Caban wrote:
> Hi Vitaliy,
>
> Vitaliy Margolen wrote:
> > This reverts commit c32cca8066807d09e3b953aee9242eba8cfa8cdb.
> >
> > This patch is obviously wrong since it broke Steam Community page.
>
> This patch is obviously good and fixed a real problem, so the problem 
> must be somewhere else. I would try to fix it, but Community tab works 
> fine for me so I can't test it.

It would be nice if you would have said something in the bug report.

It seems the problem caused by an empty content-length for the POST request. 
That might work for you because you are not behind the proxy. Proxies do not 
like that and return error. The question is then why does it work without 
your patch?

Vitaliy.

Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."

[Jacek Caban]

Vitaliy Margolen wrote:
> It seems the problem caused by an empty content-length for the POST 
> request. That might work for you because you are not behind the proxy. 
> Proxies do not like that and return error.

Does attached hack help?
> The question is then why does it work without your patch?

My patch fixed regression due to changes in urlmon that caused post data 
to be never sent.


Jacek


diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c
index 8a629d7..d638fce 100644
--- a/dlls/mshtml/persist.c
+++ b/dlls/mshtml/persist.c
@@ -84,6 +84,10 @@ static int fix_headers(char *buf, DWORD post_len)
         }
     }
 
+    for(ptr = buf; ptr[0] == '\r' && ptr[1] == '\n'; ptr += 2);
+    if(ptr != buf)
+        memmove(buf, ptr, strlen(ptr)+1);
+
     return strlen(buf);
 }
 
@@ -170,7 +174,8 @@ static nsIInputStream *get_post_data_stream(IBindCtx *bctx)
 
         TRACE("data = %s\n", debugstr_an(data, len+post_len));
 
-        ret = create_nsstream(data, len+post_len);
+        if(len)
+            ret = create_nsstream(data, len+post_len);
     }
 
     CoTaskMemFree(headers);

Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."

[Vitaliy Margolen]

Jacek Caban wrote:
> Vitaliy Margolen wrote:
> > It seems the problem caused by an empty content-length for the POST 
> > request. That might work for you because you are not behind the proxy. 
> > Proxies do not like that and return error.
>
> Does attached hack help?

Yes it does fix the problem. Thank you. So then something inserts extra 
empty line(s) between header and the body? No wonder proxy doesn't like this 
- it is an equivalent of an empty reply.

Vitaliy.

Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."

[Jacek Caban]

Vitaliy Margolen wrote:
> Yes it does fix the problem. Thank you. So then something inserts extra 
> empty line(s) between header and the body? No wonder proxy doesn't like this 
> - it is an equivalent of an empty reply.

Gecko reported in header content with length 0 (because of this empty 
line) and it caused problem for proxy. I've sent a patch to wine-patches.

Jacek