Re: [PATCH 3/3] jscript: Add error handling to Array.reverse

[Paul Vriens]

Hi Piotr,

On 01/20/2010 05:23 PM, Piotr Caban wrote:
> +        if(FAILED(hres1))
> +            return hres1;
> +
>           hres2 = jsdisp_propget_idx(jsthis, l,&v2, ei, sp);
> +        if(FAILED(hres2)) {
> +            VariantClear(&v1);
> +            return hres2;
> +        }
>
> if(hres1 == DISP_E_UNKNOWNNAME)
> -            jsdisp_delete_idx(jsthis, l);
> +            hres1 = jsdisp_delete_idx(jsthis, l);

Coverity (CID 1022) correctly spotted that the last if() will never be 
reached as we are now bailing out on a FAILED(hres1).

Could you have a look?

The same is true (me thinks) for hres2 but Coverity doesn't complain 
about that one, strange?

-- 
Cheers,

Paul.