[PATCH] Open file in binary mode to work around a windows bug

[Steven Edwards]

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Dmitry Timoshkov]

"Steven Edwards" <winehacker(a)gmail.com> wrote:
> [PATCH] Open file in binary mode to work around a windows bug

What bug is that? If that's a Windows bug why Wine needs to be patched?

-- 
Dmitry.

[Rob Shearman]

2008/9/9 Dmitry Timoshkov <dmitry(a)codeweavers.com>:
> "Steven Edwards" <winehacker(a)gmail.com> wrote:
> > [PATCH] Open file in binary mode to work around a windows bug
>
> What bug is that? If that's a Windows bug why Wine needs to be patched?

It's not a bug. When opening a file in text mode on Windows, all LFs
will be converted to CRLFs. Typelib files are binary and therefore
random parts of the typelib data
will seemingly be corrupted when read.

The patch is correct, even if the description isn't.

-- 
Rob Shearman

[Steven Edwards]

On Tue, Sep 9, 2008 at 11:10 AM, Rob Shearman <robertshearman(a)gmail.com> wrote:
> 2008/9/9 Dmitry Timoshkov <dmitry(a)codeweavers.com>:
> > "Steven Edwards" <winehacker(a)gmail.com> wrote:
> > > [PATCH] Open file in binary mode to work around a windows bug
> >
> > What bug is that? If that's a Windows bug why Wine needs to be patched?
>
> It's not a bug. When opening a file in text mode on Windows, all LFs
> will be converted to CRLFs. Typelib files are binary and therefore
> random parts of the typelib data
> will seemingly be corrupted when read.
>
> The patch is correct, even if the description isn't.

Sorry I should have said "Allow opening files in binary mode to avoid
corruption from text mode on Windows" or some such. I know the line
LF/CRLF stuff is not really a bug as there is not a standard that says
"All line endings should follow the Unix method" I just view the
historic dos/windows usage as a bug.

If Alexandre does not apply it I will resend.

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Dmitry Timoshkov]

"Steven Edwards" <winehacker(a)gmail.com> wrote:
> If Alexandre does not apply it I will resend.

Usually he doesn't apply the patches sent to wine-devel, so
you have to resend.

-- 
Dmitry.

[Steven Edwards]

On Tue, Sep 9, 2008 at 12:03 PM, Dmitry Timoshkov
<dmitry(a)codeweavers.com> wrote:
> "Steven Edwards" <winehacker(a)gmail.com> wrote:
> > If Alexandre does not apply it I will resend.
>
> Usually he doesn't apply the patches sent to wine-devel, so
> you have to resend.

Duh! I am being really careless today for some reason...

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo