Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> +    hwnd = WIN_GetFullHandle( hwnd );
>
> -    if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0;
> +    set_active_window( hwnd, &prev, FALSE, TRUE );
>      return prev;
>  }

It doesn't seem right to ignore all errors. This would need some more
tests.

-- 
Alexandre Julliard
julliard(a)winehq.org

[2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> > -    if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0;
> > +    set_active_window( hwnd, &prev, FALSE, TRUE );
> >      return prev;
> >  }
>
> It doesn't seem right to ignore all errors. This would need some more
> tests.

What kind of tests do you have in mind? Invalid window? Something else?

-- 
Dmitry.

[2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> What kind of tests do you have in mind? Invalid window? Something else?

Yes, invalid or belonging to a different thread input.

-- 
Alexandre Julliard
julliard(a)winehq.org